Groundskeeping (iOS) Master Issue : November 5 - 9

Description

This is an umbrella issue for ad hoc tasks that I take on during my Groundskeeping rotation.

(Groundskeeping) Project Issues

• Corrected a word count issue observed in the Editor.
• Investigated a refresh control issue in the Reader.
• Researched a Fabric crash related to haptic feedback on iOS 11.
• Researched a new issue where data for a single day is missing from Statistics.
• Merged an improvement integrating a filter bar into the People view.
• Merged a fix for a visual defect evident after editing the list of visible sites in My Sites.
• Researched a state defect in Notifications. The solution evaded me.

CocoaPods Administrivia

• Relaxed dependencies in conjunction with this fix.
• Absorb Swift 4.2 support : Gifu & Starscream. (PR)

Code Hygiene

• Removed unused Swift playground from the project. (PR)
• Remove obsolete available check. (PR)
• Removed obsolete usage of synchronize in/on UserDefaults. (PR)
• Removed obsolete calls to removeObserver(_:) via NotificationCenter. (PR)
• Removed superfluous nil completion handlers. (PR)
• Removed some commented out code. (PR)
• Resolved a console warning message. (PR)

Assorted PR Reviews...

[rachelmcr]

Thanks for all your groundskeeping this week!