Removed superfluous nil completion handlers #10414
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
ghost
requested a review
from 
ctarda
approved these changes
Nov 7, 2018
Contributor
ctarda
left a comment
ctarda
left a comment
There was a problem hiding this comment.
TIL those completion blocks had a default. 
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Addresses #10402.
Swift documentation advises us of the following:
This PR takes the suggestion to heart, with an emphasis on removing superfluous completion handlers found throughout the app. The most common call sites impacted are presentation & dismissal methods of
UIViewController.Testing
Checkout the branch and verify that existing tests pass. Perform a cursory "smoke test" of the app.