Skip to content

Conversation

@hassaansaleh
Copy link

@hassaansaleh hassaansaleh commented Nov 30, 2021

Fixes #17516

Associated PRs

To Test

  1. Test the unified and old UI with 1Password enabled.
  2. Test the unified and old UI with 1Password disabled (Toggle this from WordPressAuthenticationManager).
  3. Please test on a physical device to see that 1Password is passed the domain correctly. I couldn’t test this specific part as I’m testing using a custom app ID to get around code signing issues, so the associated domain isn’t linked to my version of the app. However I checked the association file here and it seems everything is setup as expected.
  4. For more detailed testing instructions, check the associated PRs

Regression Notes

  1. Potential unintended areas of impact
    No changes of significance. All changes are inside WordPress Authenticator.

  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    Tested the UI changes in WordPress Authenticator manually and added unit tests inside the helper framework.

  3. What automated tests I added (or what prevented me from doing so)
    As AutoFill Password and 1Password are not available on simulators, I wasn’t able to add UITests to cover my changes.

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@hassaansaleh hassaansaleh changed the title Issue/17516 remove 1 password Remove 1Password Usage Nov 30, 2021
@hassaansaleh hassaansaleh marked this pull request as ready for review November 30, 2021 19:03
Comment on lines +218 to +219
# pod 'WordPressAuthenticator', '~> 1.42.1'
pod 'WordPressAuthenticator', :git => 'https://github.com/hassaansaleh/WordPressAuthenticator-iOS.git', :branch => 'issue/17516-control-onePassword-with-config'
Copy link
Author

@hassaansaleh hassaansaleh Nov 30, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is temporary. Should be replaced with new version once the changes in WordPressAuthenticator-iOS are released.

@hassaansaleh hassaansaleh marked this pull request as draft November 30, 2021 19:18
@hassaansaleh
Copy link
Author

Closing this as we decided to remove 1Password completely
Check wordpress-mobile/WordPressAuthenticator-iOS#626

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant