This repository was archived by the owner on Feb 5, 2025. It is now read-only.
Completely remove 1Password dependency #626
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 3, 2021
…516-remove-1Password
Contributor
Author
|
@diegoreymendez Since this might be the last PR to be merged into this feature branch, should I bump the framework’s version or will someone else be handling this? |
Contributor
|
@hassaansaleh - Once this is ready, I'll create a PR for the feature, and the version bump can be taken care of there. |
diegoreymendez
approved these changes
Dec 8, 2021
Contributor
diegoreymendez
left a comment
diegoreymendez
left a comment
There was a problem hiding this comment.
This PR is good to go. Nice work!
diegoreymendez
merged commit c54abda
into
wordpress-mobile:feature/remove-1password-framework-usage
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR completely removes the 1Password dependency and all related files, resources and code.
The changes does not affect the unified UI, it only affects the old UI.
References: wordpress-mobile/WordPress-iOS#17516
Testing
To test this use the WordPress iOS App, but make sure to replace this line in the Podfile
pod 'WordPressAuthenticator', '~> 1.42.1'With this
pod 'WordPressAuthenticator', :git => 'https://github.com/hassaansaleh/WordPressAuthenticator-iOS.git', :branch => 'issue/17516-remove-1Password'What to test
There's nothing really to test. All changes are in the form of deletion. So just verify that 1Password buttons are removed from the old UI.