Use derived context for WeeklyRoundup background task - #17642
Merged
Conversation
|
You can trigger an installable build for these changes by visiting CircleCI here. |
4 tasks
|
You can trigger optional UI/connected tests for these changes by visiting CircleCI here. |
diegoreymendez
approved these changes
Dec 8, 2021
diegoreymendez
left a comment
Contributor
There was a problem hiding this comment.
The failing test is due to an unrelated issue with a timeout that's too aggressive.
Contributor
|
@dvdchr this has been bundled as part of 18.8 beta 4 (18.8.0.4), which is currently building in CI. Thanks for your work 🙌 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #17639
This attempts to fix a crash due to the managed object context being accessed from the wrong thread. The
WeeklyRoundupDataProvideris now initialized with a derived context so all of its operations won't be running on the main context and hopefully prevents overlap with any operations running in the main queue.To test:
Refer to the steps described in #17066 and #17116, and make sure everything works.
Regression Notes
Potential unintended areas of impact
The Weekly Roundup feature might not work as expected.
What I did to test those areas of impact (or what existing automated tests I relied on)
Manually tested the scenarios described in Local Weekly Roundup #17066 and Implement weekly roundup toggle #17116.
What automated tests I added (or what prevented me from doing so)
n/a.
PR submission checklist:
RELEASE-NOTES.txtif necessary.