Onboarding Improvements: persist the chosen site - #17643
Merged
momo-ozawa merged 2 commits intoDec 8, 2021
Merged
Conversation
added 2 commits
December 8, 2021 11:02
This fixes an issue where the incorrect site was being shown after closing then reopening the app.
|
You can trigger an installable build for these changes by visiting CircleCI here. |
|
You can trigger optional UI/connected tests for these changes by visiting CircleCI here. |
leandroalonso
approved these changes
Dec 8, 2021
momo-ozawa
deleted the
fix/onboarding-improvements-persist-chosen-site
branch
December 8, 2021 14:26
Contributor
|
@momo-ozawa this has been bundled as part of 18.8 beta 4 (18.8.0.4), which is currently building in CI. Thanks for your work 🙌 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes two issues found in Calls for Testing for 18.8
Ref: p5T066-2Rr-p2#comment-10832
How to test
Scaling font size
Persisting the selected site
Simulator.Screen.Recording.-.iPhone.13.-.2021-12-08.at.11.13.24.mp4
Regression Notes
Potential unintended areas of impact
N/A
What I did to test those areas of impact (or what existing automated tests I relied on)
N/A
What automated tests I added (or what prevented me from doing so)
N/A
PR submission checklist:
RELEASE-NOTES.txtif necessary.