Merge 18.9 code freeze into develop - #17672
Conversation
|
You can trigger an installable build for these changes by visiting CircleCI here. |
| output_dir: en_lproj | ||
| ) | ||
|
|
||
| # @TODO: Remove once we migrated the codebase of the widgets to use the app bundle for .strings |
There was a problem hiding this comment.
@AliSoftware – I needed to remove these in order to complete the code freeze – I believe these were resolve as part of #17630 and #17636 , but LMK if anything doesn't look right?
There was a problem hiding this comment.
That's correct and I should have removed those as part of those PRs, thanks for taking care of this.
There might still be an issue waiting to happen during new_beta_release and finalize_release when those will call the scripts downloading the translations from GlotPress and those scripts (which are still yet to be migrated) might still be trying to re-dispatch the keys to those widget targets based on those (now deleted) Base.lproj keys. Until that side of the migration of our scripts is over we might need to patch the extract-framework-translations.swift scripts (or even stop calling that script altogether by removing these lines) to stop doing that for those targets until I finalize the related work.
|
You can trigger optional UI/connected tests for these changes by visiting CircleCI here. |
3 participants
Merges the
18.9code freeze intodevelop, including: