Add header view to ActionSheetViewController - #18415
Merged
Merged
Conversation
wargcm
force-pushed
the
feature/18402-bottom-sheet-header-view
branch
from
April 21, 2022 18:20
2318b94 to
4fe7e52
Compare
Contributor
You can test the changes in Jetpack from this Pull Request by:
.ipa file can also be downloaded directly here.If you need access to App Center, please ask a maintainer to add you. |
Contributor
You can test the changes in WordPress from this Pull Request by:
.ipa file can also be downloaded directly here.If you need access to App Center, please ask a maintainer to add you. |
ScoutHarris
approved these changes
Apr 22, 2022
ScoutHarris
left a comment
Contributor
There was a problem hiding this comment.
Hey Chris. I had one minor comment, but otherwise looks good!
![]()
| let headerView: UIView? | ||
| let buttons: [ActionSheetButton] | ||
| let headerTitle: String | ||
| let buttonHeaderTitle: String |
Contributor
There was a problem hiding this comment.
I'm a bit confused about this name change. It looks like it's now a button title, but it's still the same header title. What it meant to clarify its use? I'm not sure it did. Maybe we can change it back?
Contributor
Author
There was a problem hiding this comment.
I can change it back. I just thought that it'd be confusing to have both the header view and something called a header title. Adding button was just to try and clarify it is the title for the buttons.
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref: #18402
Description
Allows for a header view to be added to the action sheet view controller. This will be used in a future PR for the blogging prompts header view.
Testing
To test:
Regression Notes
Potential unintended areas of impact
N/A
What I did to test those areas of impact (or what existing automated tests I relied on)
N/A
What automated tests I added (or what prevented me from doing so)
N/A
PR submission checklist:
RELEASE-NOTES.txtif necessary.