Skip to content

Blogging Prompts Feature Introduction: show post creation - #18428

Merged
ScoutHarris merged 3 commits into
trunkfrom
feature/18176-show_create_post
Apr 25, 2022
Merged

Blogging Prompts Feature Introduction: show post creation#18428
ScoutHarris merged 3 commits into
trunkfrom
feature/18176-show_create_post

Conversation

@ScoutHarris

@ScoutHarris ScoutHarris commented Apr 22, 2022

Copy link
Copy Markdown
Contributor

Ref: #18176

The default post creation view is now displayed when selecting Try it now on an account with one site. Support for multiple sites coming soon.

Random bonus: the answer count on the example card is now 19 to match the design.

To test:

  • Enable the bloggingPrompts feature.
  • Log into the app with an account that has one site.
  • On the Feature Introduction, tap Try it now.
    • Note: you may need to minimize/maximize the app after immediately logging in to get the FI to show.
  • Verify:
    • The Feature Introduction is dismissed.
    • The new post view is shown.
  • Log into the app with an account that has multiple sites.
    • On the FI, verify tapping both buttons simply dismisses the view (for now).
FI New Post
fi new_post

Regression Notes

  1. Potential unintended areas of impact
    N/A

  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    N/A

  3. What automated tests I added (or what prevented me from doing so)
    N/A

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@wpmobilebot

Copy link
Copy Markdown
Contributor
You can test the changes in Jetpack from this Pull Request by:
  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr18428-3ce2452 on your iPhone

If you need access to App Center, please ask a maintainer to add you.

@wpmobilebot

Copy link
Copy Markdown
Contributor
You can test the changes in WordPress from this Pull Request by:
  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr18428-3ce2452 on your iPhone

If you need access to App Center, please ask a maintainer to add you.

@dvdchr dvdchr left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, it works as described. Also confirmed that this is logged: 🔵 Tracked: editor_post_created <blog_id: xxxxxxx, default_tab_experiment: dashboard, post_type: post, site_type: blog, tap_source: blogging_prompts_feature_introduction>.

LGTM! :shipit:

@ScoutHarris
ScoutHarris merged commit 797b570 into trunk Apr 25, 2022
@ScoutHarris
ScoutHarris deleted the feature/18176-show_create_post branch April 25, 2022 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants