Blogging Prompts: Move shared blogging prompt styles into an extension - #18453
Merged
Conversation
Contributor
You can test the changes in Jetpack from this Pull Request by:
|
Contributor
You can test the changes in WordPress from this Pull Request by:
|
4 tasks
ScoutHarris
approved these changes
Apr 26, 2022
| let label = UILabel() | ||
| label.translatesAutoresizingMaskIntoConstraints = false | ||
| label.font = Style.promptContentFont | ||
| label.font = WPStyleGuide.BloggingPrompts.promptContentFont |
Contributor
There was a problem hiding this comment.
Just an FYI. The style names can get long, so sometimes we typealias them to something shorter, for example private typealias Style = WPStyleGuide.BloggingPrompts. You can do so if you like, either way is fine, just letting you know.
Contributor
Author
There was a problem hiding this comment.
For now, I think it's still alright since there's no nesting under the BloggingPrompts struct. If we add additional objects or some of the names get a little long, then we could probably do that.
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ref #18402
Description
Moves some styling out of the dashboard prompt cell into a
WPStyleGuideextension. These will be used by another view with similar UI.Testing
To test:
Regression Notes
Potential unintended areas of impact
N/A
What I did to test those areas of impact (or what existing automated tests I relied on)
N/A
What automated tests I added (or what prevented me from doing so)
N/A
PR submission checklist:
RELEASE-NOTES.txtif necessary.