Skip to content

Blogging Prompts: Move shared blogging prompt styles into an extension - #18453

Merged
wargcm merged 1 commit into
trunkfrom
feature/18402-shared-prompt-styles
Apr 27, 2022
Merged

Blogging Prompts: Move shared blogging prompt styles into an extension#18453
wargcm merged 1 commit into
trunkfrom
feature/18402-shared-prompt-styles

Conversation

@wargcm

@wargcm wargcm commented Apr 26, 2022

Copy link
Copy Markdown
Contributor

Ref #18402

Description

Moves some styling out of the dashboard prompt cell into a WPStyleGuide extension. These will be used by another view with similar UI.

Testing

To test:

  • Enable blogging prompts feature flag
  • Navigate to my site tab
  • Verify blogging prompts card displays the same as previously

Regression Notes

  1. Potential unintended areas of impact
    N/A

  2. What I did to test those areas of impact (or what existing automated tests I relied on)
    N/A

  3. What automated tests I added (or what prevented me from doing so)
    N/A

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@wargcm wargcm added this to the 19.8 milestone Apr 26, 2022
@wargcm
wargcm requested a review from ScoutHarris April 26, 2022 20:49
@wargcm wargcm self-assigned this Apr 26, 2022
@wpmobilebot

Copy link
Copy Markdown
Contributor
You can test the changes in Jetpack from this Pull Request by:
  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr18453-bd05911 on your iPhone

If you need access to App Center, please ask a maintainer to add you.

@wpmobilebot

Copy link
Copy Markdown
Contributor
You can test the changes in WordPress from this Pull Request by:
  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr18453-bd05911 on your iPhone

If you need access to App Center, please ask a maintainer to add you.

@ScoutHarris ScoutHarris left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

:shipit:

let label = UILabel()
label.translatesAutoresizingMaskIntoConstraints = false
label.font = Style.promptContentFont
label.font = WPStyleGuide.BloggingPrompts.promptContentFont

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just an FYI. The style names can get long, so sometimes we typealias them to something shorter, for example private typealias Style = WPStyleGuide.BloggingPrompts. You can do so if you like, either way is fine, just letting you know.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For now, I think it's still alright since there's no nesting under the BloggingPrompts struct. If we add additional objects or some of the names get a little long, then we could probably do that.

@wargcm
wargcm merged commit cec3e1f into trunk Apr 27, 2022
@wargcm
wargcm deleted the feature/18402-shared-prompt-styles branch April 27, 2022 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants