Create a XCTestCase subclass to manage CoreDataStack mock implementation - #18578
Merged
mokagio merged 3 commits intoMay 17, 2022
Merged
Conversation
I've selected a few existing test cases which use `ContextManagerMock` differently, changed them to use `CoreDataTestCase` to see how this new subclass works with different scenarios. Rest of the test cases will be updated to use `CoreDataTestCase` after this commit is reviewed.
jkmassel
self-requested a review
May 12, 2022 01:47
4 tasks
jkmassel
approved these changes
May 12, 2022
Merged
Conflicts: WordPress/WordPress.xcodeproj/project.pbxproj
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's suggested in #18527 (comment) to create a
XCTestCasesubclass to manageContextManagerMock, which I think would be very useful in lots of test cases.Changes
This PR added a
CoreDataTestCasewhich creates aContextManagerMockinstance for its subclass to use. A few unit tests were modified to inherit from this new subclass, as a simple demonstration of how the mock implement can be used in subclasses.After this PR is merged, I'll create a follow-up PR which changes rest of unit tests to use the new
CoreDataTestCase.Test Instructions
Make sure all tests pass.
Regression Notes
N/A. Only unit test target is affected.
PR submission checklist:
RELEASE-NOTES.txtif necessary.