Jetpack Overlay - Add dismiss button - #19182
Merged
Merged
Conversation
added 6 commits
August 12, 2022 09:20
…for just the button image
Gio2018
requested review from
a team,
alpavanoglu,
shaunandrews,
sla8c and
twstokes
August 12, 2022 14:38
Contributor
You can test the changes in Jetpack from this Pull Request by:
|
Contributor
You can test the changes in WordPress from this Pull Request by:
|
twstokes
reviewed
Aug 15, 2022
twstokes
left a comment
Contributor
There was a problem hiding this comment.
👋 This is looking good! I left a comment on the PR.
I tested:
- Light / Dark mode
- iPhone / iPad
- VoiceOver
twstokes
approved these changes
Aug 15, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #19177
This PR adds an "x" dismiss button to the top-trailing corner of the Jetpack overlay.
It also contains some layout and fonts adjustments, as well as an updated logo animation.
Known issues: the landscape layout will be addressed in a separate PR
To test:
jetpackBottomSheetfeature flagRegression Notes
Potential unintended areas of impact
None
What I did to test those areas of impact (or what existing automated tests I relied on)
What automated tests I added (or what prevented me from doing so)
PR submission checklist:
I have considered if this change warrants user-facing release notes and have added them toNot releasedRELEASE-NOTES.txtif necessary.