Skip to content

Jetpack Overlay - Add dismiss button - #19182

Merged
Gio2018 merged 11 commits into
trunkfrom
task/jetpack-overlay-dismiss-button
Aug 15, 2022
Merged

Jetpack Overlay - Add dismiss button#19182
Gio2018 merged 11 commits into
trunkfrom
task/jetpack-overlay-dismiss-button

Conversation

@Gio2018

@Gio2018 Gio2018 commented Aug 12, 2022

Copy link
Copy Markdown
Contributor

Fixes #19177

This PR adds an "x" dismiss button to the top-trailing corner of the Jetpack overlay.
It also contains some layout and fonts adjustments, as well as an updated logo animation.

dark mode light mode

Known issues: the landscape layout will be addressed in a separate PR

To test:

  • Checkout this branch and enable the jetpackBottomSheet feature flag
  • Build/run
  • Go to My Site/Home
  • Tap the "Jetpack powered" badge
  • Make sure the overlay appears, and contains a dismiss button on the top-trailing corner
  • Tap that button, and make sure the overlay dismisses itself

Regression Notes

  1. Potential unintended areas of impact
    None

  2. What I did to test those areas of impact (or what existing automated tests I relied on)

  3. What automated tests I added (or what prevented me from doing so)

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary. Not released

@Gio2018 Gio2018 added this to the 20.6 milestone Aug 12, 2022
@Gio2018
Gio2018 requested review from a team, alpavanoglu, shaunandrews, sla8c and twstokes August 12, 2022 14:38
@Gio2018 Gio2018 self-assigned this Aug 12, 2022
@wpmobilebot

wpmobilebot commented Aug 12, 2022

Copy link
Copy Markdown
Contributor
You can test the changes in Jetpack from this Pull Request by:
  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr19182-61df373 on your iPhone

If you need access to App Center, please ask a maintainer to add you.

@wpmobilebot

wpmobilebot commented Aug 12, 2022

Copy link
Copy Markdown
Contributor
You can test the changes in WordPress from this Pull Request by:
  • Clicking here or scanning the QR code below to access App Center
  • Then installing the build number pr19182-61df373 on your iPhone

If you need access to App Center, please ask a maintainer to add you.

@Gio2018
Gio2018 requested a review from guarani August 15, 2022 15:39

@twstokes twstokes left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋 This is looking good! I left a comment on the PR.

I tested:

  • Light / Dark mode
  • iPhone / iPad
  • VoiceOver

@Gio2018
Gio2018 requested a review from twstokes August 15, 2022 16:09

@twstokes twstokes left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @Gio2018! 🚀

@Gio2018
Gio2018 merged commit e5c5153 into trunk Aug 15, 2022
@Gio2018
Gio2018 deleted the task/jetpack-overlay-dismiss-button branch August 15, 2022 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[iOS] Jetpack overlay - Add dismiss button ("x") in the top/right to dismiss the overlay

3 participants