Fix an issue where the persistentContainer ivar isn't set - #19210
Merged
Conversation
Contributor
You can test the changes in Jetpack from this Pull Request by:
|
Contributor
You can test the changes in WordPress from this Pull Request by:
|
mokagio
approved these changes
Aug 19, 2022
mokagio
left a comment
Contributor
There was a problem hiding this comment.
This definitely looks like the kind of tiny bug that would take ages to discover. Sorry you had to go through it, and thank you for shipping a fix. 🙇♂️
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
The
_persistentStoreCoordinatorinstance variable is never assigned a value in its lazy getter. This is going to be an issue if the getter is called multiple times, which isn't the case now. But I wasted a few hours on this issue when making other changes.Test instructions
Unit and UI test suite should be able to cover this change.
Regression Notes
Potential unintended areas of impact
None
What I did to test those areas of impact (or what existing automated tests I relied on)
None
What automated tests I added (or what prevented me from doing so)
None
PR submission checklist:
RELEASE-NOTES.txtif necessary.