-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Use Ruby 1.9 hash syntax in Podfile suggestion comments
#19963
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This should avoid noisy lint errors such as this #19807 (comment)
Podfile
Outdated
|
|
||
| pod 'WPMediaPicker', '~> 1.8.7' | ||
| # pod 'WPMediaPicker', :git => 'https://github.com/wordpress-mobile/MediaPicker-iOS.git', :tag => '1.7.0' | ||
| # pod 'WPMediaPicker', git: 'https://github.com/wordpress-mobile/MediaPicker-iOS.git', tag: '1.7.0' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, we should delete this because it adds little to what we can already do with the standard syntax.
I suppose it might have been useful in the past, before we had our own specs source repository.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| # pod 'WPMediaPicker', git: 'https://github.com/wordpress-mobile/MediaPicker-iOS.git', tag: '1.7.0' |
46745e7 to
880311f
Compare
You can test the changes in Jetpack from this Pull Request by:
|
You can test the changes in WordPress from this Pull Request by:
|
This should avoid noisy lint errors such as this
#19807 (comment)
The method I used to make these changes was to uncomment all the suggestions, run RuboCop with
-A, and recomment.Testing
This PR only touches comments. So there's nothing to test.
Regression Notes
RELEASE-NOTES.txtif necessary. N.A.