Skip to content

Use Ruby 1.9 hash syntax in Podfile suggestion comments #19963

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jan 23, 2023
Merged

Use Ruby 1.9 hash syntax in Podfile suggestion comments #19963

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d972029
Use Ruby 1.9 hash syntax in `Podfile` suggestion comments
mokagio Jan 23, 2023
71909a8
Remove leftover commit SHA1 from `Podfile` suggestion comment
mokagio Jan 23, 2023
880311f
Remove unnecessary `tag:` suggestion comment from `Podfile`
mokagio Jan 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
47 changes: 23 additions & 24 deletions Podfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,34 +31,34 @@ def aztec
## When using a tagged version, feel free to comment out the WordPress-Aztec-iOS line below.
## When using a commit number (during development) you should provide the same commit number for both pods.
##
# pod 'WordPress-Aztec-iOS', :git => 'https://github.com/wordpress-mobile/AztecEditor-iOS.git', :commit => ''
# pod 'WordPress-Editor-iOS', :git => 'https://github.com/wordpress-mobile/AztecEditor-iOS.git', :commit => ''
# pod 'WordPress-Editor-iOS', :git => 'https://github.com/wordpress-mobile/AztecEditor-iOS.git', :tag => ''
# pod 'WordPress-Editor-iOS', :path => '../AztecEditor-iOS'
# pod 'WordPress-Aztec-iOS', git: 'https://github.com/wordpress-mobile/AztecEditor-iOS.git', commit: ''
# pod 'WordPress-Editor-iOS', git: 'https://github.com/wordpress-mobile/AztecEditor-iOS.git', commit: ''
# pod 'WordPress-Editor-iOS', git: 'https://github.com/wordpress-mobile/AztecEditor-iOS.git', tag: ''
# pod 'WordPress-Editor-iOS', path: '../AztecEditor-iOS'
pod 'WordPress-Editor-iOS', '~> 1.19.8'
end

def wordpress_ui
pod 'WordPressUI', '~> 1.12.5'
# pod 'WordPressUI', :git => 'https://github.com/wordpress-mobile/WordPressUI-iOS', :tag => ''
# pod 'WordPressUI', :git => 'https://github.com/wordpress-mobile/WordPressUI-iOS', :branch => ''
# pod 'WordPressUI', :git => 'https://github.com/wordpress-mobile/WordPressUI-iOS', :commit => ''
# pod 'WordPressUI', :path => '../WordPressUI-iOS'
# pod 'WordPressUI', git: 'https://github.com/wordpress-mobile/WordPressUI-iOS', tag: ''
# pod 'WordPressUI', git: 'https://github.com/wordpress-mobile/WordPressUI-iOS', branch: ''
# pod 'WordPressUI', git: 'https://github.com/wordpress-mobile/WordPressUI-iOS', commit: ''
# pod 'WordPressUI', path: '../WordPressUI-iOS'
end

def wordpress_kit
pod 'WordPressKit', '~> 5.0'
# pod 'WordPressKit', :git => 'https://github.com/wordpress-mobile/WordPressKit-iOS.git', :tag => ''
# pod 'WordPressKit', :git => 'https://github.com/wordpress-mobile/WordPressKit-iOS.git', :branch => ''
# pod 'WordPressKit', :git => 'https://github.com/wordpress-mobile/WordPressKit-iOS.git', :commit => ''
# pod 'WordPressKit', :path => '../WordPressKit-iOS'
# pod 'WordPressKit', git: 'https://github.com/wordpress-mobile/WordPressKit-iOS.git', tag: ''
# pod 'WordPressKit', git: 'https://github.com/wordpress-mobile/WordPressKit-iOS.git', branch: ''
# pod 'WordPressKit', git: 'https://github.com/wordpress-mobile/WordPressKit-iOS.git', commit: ''
# pod 'WordPressKit', path: '../WordPressKit-iOS'
end

def kanvas
pod 'Kanvas', '~> 1.4.4'
# pod 'Kanvas', :git => 'https://github.com/tumblr/Kanvas-iOS.git', :tag => ''
# pod 'Kanvas', :git => 'https://github.com/tumblr/Kanvas-iOS.git', :commit => ''
# pod 'Kanvas', :path => '../Kanvas-iOS'
# pod 'Kanvas', git: 'https://github.com/tumblr/Kanvas-iOS.git', tag: ''
# pod 'Kanvas', git: 'https://github.com/tumblr/Kanvas-iOS.git', commit: ''
# pod 'Kanvas', path: '../Kanvas-iOS'
end

def shared_with_all_pods
Expand Down Expand Up @@ -219,28 +219,27 @@ abstract_target 'Apps' do

pod 'Automattic-Tracks-iOS', '~> 0.13'
# While in PR
# pod 'Automattic-Tracks-iOS', :git => 'https://github.com/Automattic/Automattic-Tracks-iOS.git', :branch => ''
# pod 'Automattic-Tracks-iOS', git: 'https://github.com/Automattic/Automattic-Tracks-iOS.git', branch: ''
# Local Development
# pod 'Automattic-Tracks-iOS', :path => '~/Projects/Automattic-Tracks-iOS'
# pod 'Automattic-Tracks-iOS', path: '~/Projects/Automattic-Tracks-iOS'

pod 'NSURL+IDN', '~> 0.4'

pod 'WPMediaPicker', '~> 1.8.7'
# pod 'WPMediaPicker', :git => 'https://github.com/wordpress-mobile/MediaPicker-iOS.git', :tag => '1.7.0'
## while PR is in review:
# pod 'WPMediaPicker', :git => 'https://github.com/wordpress-mobile/MediaPicker-iOS.git', :branch => ''
# pod 'WPMediaPicker', :path => '../MediaPicker-iOS'
# pod 'WPMediaPicker', git: 'https://github.com/wordpress-mobile/MediaPicker-iOS.git', branch: ''
# pod 'WPMediaPicker', path: '../MediaPicker-iOS'

pod 'Gridicons', '~> 1.1.0'

pod 'WordPressAuthenticator', '~> 5.1.0-beta.1'
# pod 'WordPressAuthenticator', git: 'https://github.com/wordpress-mobile/WordPressAuthenticator-iOS.git', branch: 'trunk'
# pod 'WordPressAuthenticator', :git => 'https://github.com/wordpress-mobile/WordPressAuthenticator-iOS.git', :commit => ''
# 'WordPressAuthenticator', :path => '../WordPressAuthenticator-iOS'
# pod 'WordPressAuthenticator', git: 'https://github.com/wordpress-mobile/WordPressAuthenticator-iOS.git', commit: ''
# pod 'WordPressAuthenticator', path: '../WordPressAuthenticator-iOS'

pod 'MediaEditor', '~> 1.2.1'
# pod 'MediaEditor', :git => 'https://github.com/wordpress-mobile/MediaEditor-iOS.git', :commit => 'a4178ed9b0f3622faafb41dd12503e26c5523a32'
# pod 'MediaEditor', :path => '../MediaEditor-iOS'
# pod 'MediaEditor', git: 'https://github.com/wordpress-mobile/MediaEditor-iOS.git', commit: ''
# pod 'MediaEditor', path: '../MediaEditor-iOS'

aztec
wordpress_ui
Expand Down
2 changes: 1 addition & 1 deletion Podfile.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -892,6 +892,6 @@ SPEC CHECKSUMS:
ZendeskSupportSDK: 3a8e508ab1d9dd22dc038df6c694466414e037ba
ZIPFoundation: ae5b4b813d216d3bf0a148773267fff14bd51d37

PODFILE CHECKSUM: f8308fda9ad581e150fd428153ddb030464fe36b
PODFILE CHECKSUM: 9a5962a15ab668001aeacd90bcfbf145409101c9

COCOAPODS: 1.11.2