Add a feature flag to enable using URLSession in WordPressKit - #22540
Merged
Conversation
This was referenced Feb 5, 2024
Contributor
|
| App Name |  WordPress Alpha |
|
| Configuration | Release-Alpha | |
| Build Number | pr22540-1142472 | |
| Version | 24.2 | |
| Bundle ID | org.wordpress.alpha | |
| Commit | 1142472 | |
| App Center Build | WPiOS - One-Offs #8710 |
Contributor
|
| App Name |  Jetpack Alpha |
|
| Configuration | Release-Alpha | |
| Build Number | pr22540-1142472 | |
| Version | 24.2 | |
| Bundle ID | com.jetpack.alpha | |
| Commit | 1142472 | |
| App Center Build | jetpack-installable-builds #7737 |
crazytonyli
force-pushed
the
wordpresskit-error-refactor
branch
from
February 6, 2024 22:19
76c50cc to
07f528c
Compare
crazytonyli
marked this pull request as ready for review
February 7, 2024 01:12
mokagio
approved these changes
Feb 7, 2024
| case .newTabIcons: | ||
| return true | ||
| case .useURLSession: | ||
| return BuildConfiguration.current != .appStore |
Contributor
There was a problem hiding this comment.
Did you consider making this a remote flag?
Contributor
Author
There was a problem hiding this comment.
| if FeatureFlag.useURLSession.enabled { | ||
| WordPressComRestApi.useURLSession = true | ||
| WordPressOrgXMLRPCApi.useURLSession = true | ||
| } |
Contributor
There was a problem hiding this comment.
Nitpick: I liked how the WooCommerce counterpart has this in a dedicated function. I feel like it's a great way to keep the configuration cod eat this level tidier.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The feature flag is enabled for all non-production builds.
Test Instructions
With the feature flag turned on, try features that involves different kinds of HTTP requests, i.e. using self hosted sites, uploading an image/video, deleting a post, updating a post, etc.
Testing error cases would be super valuable too.
Regression Notes
Potential unintended areas of impact
None.
What I did to test those areas of impact (or what existing automated tests I relied on)
What's described in the Test Instructions section.
What automated tests I added (or what prevented me from doing so)
None.
PR submission checklist:
RELEASE-NOTES.txtif necessary.UI Changes testing checklist: N/A