Skip to content

Hot Fix: Open AppStore directly rather than through SKStoreProductViewController#23276

Merged
guarani merged 2 commits into
release/24.9.1from
fix/migration-app-store-not-opening
May 30, 2024
Merged

Hot Fix: Open AppStore directly rather than through SKStoreProductViewController#23276
guarani merged 2 commits into
release/24.9.1from
fix/migration-app-store-not-opening

Conversation

@staskus

@staskus staskus commented May 30, 2024

Copy link
Copy Markdown
Contributor

Context: p1717015105844129-slack-C012H19SZQ8

"Switch to Jetpack app" doesn't work on full-screen pop-up overlays. It happens because full-screen overlays are presented on separate windows, and "Switch to Jetpack app" tries to show SKStoreProductViewController on a topmost view controller on the main window.

To fix presentation issues and avoid substantial navigation changes for a hotifx, I'm reverting to safe option of opening the App Store directly

To test:

  1. Fresh install the WordPress app
  2. Login to a new account
  3. Observe the full screen popover appear
  4. Tap "Switch to Jetpack app"
  5. Confirm AppStore is opened
  6. Install the app
  7. Confirm "Switch to Jetpack app" open the app

Regression Notes

  1. Potential unintended areas of impact

I'm reverting to a previous solution. Opening UIApplication will get around any internal presentation issues.

  1. What I did to test those areas of impact (or what existing automated tests I relied on)

Manual testing

  1. What automated tests I added (or what prevented me from doing so)

PR submission checklist:

  • I have completed the Regression Notes.
  • I have considered adding unit tests for my changes.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

Testing checklist:

  • WordPress.com sites and self-hosted Jetpack sites.
  • Portrait and landscape orientations.
  • Light and dark modes.
  • Fonts: Larger, smaller and bold text.
  • High contrast.
  • VoiceOver.
  • Languages with large words or with letters/accents not frequently used in English.
  • Right-to-left languages. (Even if translation isn’t complete, formatting should still respect the right-to-left layout)
  • iPhone and iPad.
  • Multi-tasking: Split view and Slide over. (iPad)

SKStoreProductViewController is being opened in different flows, some of which are opened on separate UIWindows. SKStoreProductViewController has strict rules of presentation, one of which is it has to be presented in a separate modal view. To avoid issues such as these, I'm reverting to a safe option of opening AppStore directly
@staskus staskus added this to the 24.9.1 milestone May 30, 2024
@staskus staskus requested a review from guarani May 30, 2024 08:40
@dangermattic

dangermattic commented May 30, 2024

Copy link
Copy Markdown
Collaborator
1 Warning
⚠️ This PR is assigned to the milestone 24.9.1. The due date for this milestone has already passed.
Please assign it to a milestone with a later deadline or check whether the release for this milestone has already been finished.
1 Message
📖 This PR contains changes to RELEASE-NOTES.txt.
Note that these changes won't affect the final version of the release notes as this version is in code freeze.
Please, get in touch with a release manager if you want to update the final release notes.

Generated by 🚫 Danger

@wpmobilebot

wpmobilebot commented May 30, 2024

Copy link
Copy Markdown
Contributor
WordPress Alpha📲 You can test the changes from this Pull Request in WordPress Alpha by scanning the QR code below to install the corresponding build.
App NameWordPress Alpha WordPress Alpha
ConfigurationRelease-Alpha
Build Numberpr23276-e75a1dd
Version24.9.1
Bundle IDorg.wordpress.alpha
Commite75a1dd
App Center BuildWPiOS - One-Offs #10029
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@wpmobilebot

wpmobilebot commented May 30, 2024

Copy link
Copy Markdown
Contributor
Jetpack Alpha📲 You can test the changes from this Pull Request in Jetpack Alpha by scanning the QR code below to install the corresponding build.
App NameJetpack Alpha Jetpack Alpha
ConfigurationRelease-Alpha
Build Numberpr23276-e75a1dd
Version24.9.1
Bundle IDcom.jetpack.alpha
Commite75a1dd
App Center Buildjetpack-installable-builds #9079
Automatticians: You can use our internal self-serve MC tool to give yourself access to App Center if needed.

@guarani guarani left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I tested it and it works well, it essentially reverts #21896 👍

Some observations

  • the StoreKit import is no longer used
  • I think release notes for the 24.9.1 are needed

@guarani

guarani commented May 30, 2024

Copy link
Copy Markdown
Contributor

I removed the StoreKit import and added release notes.

The failing PR checks are due to a known issue and are not required (see p1716841230344599/1716839034.013489-slack-C06CKSPHYA1).

@guarani guarani merged commit dfc41d8 into release/24.9.1 May 30, 2024
@guarani guarani deleted the fix/migration-app-store-not-opening branch May 30, 2024 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants