Hot Fix: Open AppStore directly rather than through SKStoreProductViewController#23276
Merged
Merged
Conversation
SKStoreProductViewController is being opened in different flows, some of which are opened on separate UIWindows. SKStoreProductViewController has strict rules of presentation, one of which is it has to be presented in a separate modal view. To avoid issues such as these, I'm reverting to a safe option of opening AppStore directly
Collaborator
Generated by 🚫 Danger |
Contributor
|
| App Name | WordPress Alpha |
|
| Configuration | Release-Alpha | |
| Build Number | pr23276-e75a1dd | |
| Version | 24.9.1 | |
| Bundle ID | org.wordpress.alpha | |
| Commit | e75a1dd | |
| App Center Build | WPiOS - One-Offs #10029 |
Contributor
|
| App Name | Jetpack Alpha |
|
| Configuration | Release-Alpha | |
| Build Number | pr23276-e75a1dd | |
| Version | 24.9.1 | |
| Bundle ID | com.jetpack.alpha | |
| Commit | e75a1dd | |
| App Center Build | jetpack-installable-builds #9079 |
Contributor
|
I removed the StoreKit import and added release notes. The failing PR checks are due to a known issue and are not required (see p1716841230344599/1716839034.013489-slack-C06CKSPHYA1). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


Context: p1717015105844129-slack-C012H19SZQ8
"Switch to Jetpack app" doesn't work on full-screen pop-up overlays. It happens because full-screen overlays are presented on separate windows, and "Switch to Jetpack app" tries to show
SKStoreProductViewControlleron a topmost view controller on the main window.To fix presentation issues and avoid substantial navigation changes for a hotifx, I'm reverting to safe option of opening the App Store directly
To test:
Regression Notes
I'm reverting to a previous solution. Opening
UIApplicationwill get around any internal presentation issues.Manual testing
PR submission checklist:
RELEASE-NOTES.txtif necessary.Testing checklist: