Remove dead internal app-icon versioning task#25806
Merged
Merged
Conversation
The `assets:check` Rake task generated a version-stamped internal app icon via `Scripts/BuildPhases/AddVersionToIcons.sh`, falling back to copying `AppIcon.appiconset` into `AppIcon-Internal.appiconset` when the script failed. All three are already gone — the script was deleted and the app icons moved to `Sources/*/Resources/Assets.xcassets/` (targets use `AppIconLegacy`) — so the task's skip-guard globbed a path that no longer exists, ran on every `rake dependencies`, and printed a spurious `cp` error when the deleted source appiconset wasn't found. Remove the task, unwire it from `dependencies`, and drop the stale `.gitignore` entries for the generated internal-icon paths. ImageMagick, Ghostscript, and RMagick are left in place — they back the promo-screenshots lane, not this task.
jkmassel
marked this pull request as ready for review
July 20, 2026 17:57
jkmassel
enabled auto-merge
July 20, 2026 17:58
Contributor
|
| App Name | WordPress | |
| Configuration | Release-Alpha | |
| Build Number | 33269 | |
| Version | PR #25806 | |
| Bundle ID | org.wordpress.alpha | |
| Commit | e5471ef | |
| Installation URL | 4tmpf7jneflt0 |
Contributor
|
| App Name | Jetpack | |
| Configuration | Release-Alpha | |
| Build Number | 33269 | |
| Version | PR #25806 | |
| Bundle ID | com.jetpack.alpha | |
| Commit | e5471ef | |
| Installation URL | 10p9hhs8mt8j8 |
Contributor
🤖 Build Failure AnalysisThis build has failures. Claude has analyzed them - check the build annotations for details. |
mokagio
approved these changes
Jul 20, 2026
mokagio
left a comment
mokagio
left a comment
Contributor
There was a problem hiding this comment.
Aside from a welcome cleanup, I love seeing Rakefile shrinking! So confusing to have it and Fastfile.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
assets:checkRake task that generated a version-stamped "internal" app icon.cp: .../AppIcon.appiconset: No such file or directoryerror printed during everyrake dependencies.Root Cause
assets:check— wired into the top-leveldependenciestask — did three things, all now pointing at deleted paths:next unless Dir['WordPress/Resources/AppImages.xcassets/AppIcon-Internal.appiconset/*.png'].empty?. That directory no longer exists, so the glob is always empty and the task body always ran../Scripts/BuildPhases/AddVersionToIcons.sh, which was deleted. Its non-zero exit was swallowed by>/dev/null 2>&1.cp'dWordPress/Resources/AppImages.xcassets/AppIcon.appiconset/*.pnginto the internal appiconset. That source was removed in Update resources #24410 when the app icons moved toSources/*/Resources/Assets.xcassets/AppIconLegacy.appiconset— hence thecperror.configure_applysucceeds independently; the error was purely this trailing dead step running afterward.Changes
namespace :assetsblock and dropassets:checkfrom thedependenciestask list.AppIcon-Internal.appiconsetpaths andIcons-Internal).What this deliberately leaves alone
ImageMagick, Ghostscript, and the
rmagickgem stay — they aren't icon-overlay dependencies. They back the promo-screenshots lane (fastlane/lanes/screenshots.rb→promo_screenshots). Thebrew install imagemagick/ghostscriptinshared-set-up-distribution.shmay now be unused by distribution builds — it predates and outlived the icon overlay — but confirming that needs a separate pass through the build lanes, so it's left out of scope here.Test plan
ruby -c Rakefile→Syntax OKrake dependenciescompletes without thecperrorAppIconLegacy)