Fixes an isuse where back up logs show up in Personal plan sites - #25894
Open
crazytonyli wants to merge 3 commits into
Open
Fixes an isuse where back up logs show up in Personal plan sites#25894crazytonyli wants to merge 3 commits into
crazytonyli wants to merge 3 commits into
Conversation
The wpcom activity endpoint returns backup and scan events to every site that has them indexed and expects clients to filter. The web Activity Log excludes the rewind and scan groups for sites without the backups-self-serve feature, but the apps sent no such filter, so a Personal plan Simple site showed "Backup and scan complete" entries that never appear on the web (WordPress.com backs up Simple sites internally regardless of plan). Mirror the web client: add a notGroup parameter to ActivityServiceRemote's activity and activity group requests, and have ActivityLogsViewModel pass not_group=rewind,scan when the site's plan features (plan.features.active, already synced to Blog.planActiveFeatures) lack backups-self-serve. The same exclusion applies to the activity type filter list so the hidden groups cannot be selected. The backup list is exempt because it only shows rewindable events, which all belong to the rewind group. CMM-2130
Collaborator
Generated by 🚫 Danger |
Contributor
|
| App Name | WordPress | |
| Configuration | Release-Alpha | |
| Build Number | 33760 | |
| Version | PR #25894 | |
| Bundle ID | org.wordpress.alpha | |
| Commit | 7553c58 | |
| Installation URL | 115ts038q8o0o |
Contributor
|
| App Name | Jetpack | |
| Configuration | Release-Alpha | |
| Build Number | 33760 | |
| Version | PR #25894 | |
| Bundle ID | com.jetpack.alpha | |
| Commit | 7553c58 | |
| Installation URL | 5ikglg6ockrcg |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes https://linear.app/a8c/issue/CMM-2130
Replicate this wp-calypso change. I'm not sure why this change is not done on the API endpoint, though. Maybe we don't want to affect other endpoint consumers?
Testing instructions
I can't reproduce the issue following the steps described in the Linear issue. You can give it go. Or, you can ask to join the test site mentioned in the Linear issue comments.