This repository was archived by the owner on Feb 5, 2025. It is now read-only.
[Dark Mode] Update activity indicator color when button is disabled #142
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit dd486ac.
1 task
frosty
approved these changes
Oct 2, 2019
Contributor
frosty
left a comment
frosty
left a comment
There was a problem hiding this comment.
Just one question, otherwise looks good!
| configureAppearance() | ||
| activityIndicator.style = .gray | ||
| guard #available(iOS 13, *) else { | ||
| activityIndicator.style = .gray |
Contributor
There was a problem hiding this comment.
Do we need this? Should we just initialise the indicator with a .gray appearance instead of white?
danielebogo
force-pushed
the
fix/140-nux-button-indicator-color
branch
from
c48df24 to
0337c04
Compare
# Conflicts: # WordPressAuthenticator.podspec
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #140
This PR reload the activity indicator color when the button
isEnabledproperty is true/falseTo Test