Skip to content
This repository was archived by the owner on Feb 5, 2025. It is now read-only.

Conversation

@mindgraffiti
Copy link
Contributor

@mindgraffiti mindgraffiti commented Jul 13, 2018

Fixes #15

Background: In WCiOS (host app) all UIButton instances had their UIAppearance set with a text color of wooPurple. Setting UIAppearance for all UIButton instances causes bugs because it's too general. For example, the Logout button should be a dark red "destructive action" color, but it's purple.

To Test

  1. check out this branch
  2. check out the host app branch: Configure subheadline button title color in WordPressAuthenticatorStyles woocommerce/woocommerce-ios#154
  3. delete any existing WCiOS app builds
  4. open WCiOS podfile
  5. point to the WordPressAuthenticator development pod (pod 'WordPressAuthenticator', :path => '/your/path/to/WPAuth'
  6. pod install
  7. run WCiOS
  8. verify the subheadline buttons remain purple (see list of button titles below)
  9. attempt to paste some text into the password field the "Paste" tooltip should have a white text color instead of purple.
  10. after logging in, an "Unable to find WooCommerce stores connected to this account" message will appear. Tap the "Continue" button.
  11. navigate to Orders > select an order > check the "Fulfill order" button. The button text color should be white.

Subheadline buttons found in WPAuth

(Not all of these buttons appear in WCiOS.)

  • Log in with Google
  • Log in by entering your site address
  • Enter your password instead
  • Forgot password
  • Lost your password
  • Send another code
  • Need help finding your site address

Title color issues checklist

  • Paste tooltip is white text not purple

screen shot 2018-07-11 at 12 23 20 pm

  • Fulfill order button has white text not purple

screen shot 2018-07-13 at 10 47 22 am

Copy link
Contributor

@jleandroperez jleandroperez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified via WPiOS #98781 and WCiOS #154.

Nice work @mindgraffiti !!

@mindgraffiti mindgraffiti merged commit 5b6cb16 into develop Jul 17, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants