Skip to content

Conversation

@mindgraffiti
Copy link
Contributor

@mindgraffiti mindgraffiti commented Jul 13, 2018

Fixes #151.

Background: In WCiOS (host app) all UIButton instances had their UIAppearance set with a text color of wooPurple. Setting UIAppearance for all UIButton instances causes bugs because it's too general. For example, the Logout button should be a dark red "destructive action" color, but it's purple.

To Test

  1. check out this branch
  2. check out this WPAuth branch: Configure subheadline button title color wordpress-mobile/WordPressAuthenticator-iOS#16
  3. build / run WPAuth framework
  4. delete any existing WCiOS app builds
  5. open WCiOS podfile
  6. point to the WordPressAuthenticator development pod (pod 'WordPressAuthenticator', :path => '/your/path/to/WPAuth'
  7. pod install
  8. run WCiOS
  9. verify the subheadline buttons remain purple (see list of button titles below)
  10. attempt to paste some text into the password field the "Paste" tooltip should have a white text color instead of purple.
  11. after logging in, an "Unable to find WooCommerce stores connected to this account" message will appear. Tap the "Continue" button.
  12. navigate to Orders > select an order > check the "Fulfill order" button. The button text color should be white.

Subheadline buttons found in WPAuth

(Not all of these buttons appear in WCiOS.)

  • Log in with Google
  • Log in by entering your site address
  • Enter your password instead
  • Forgot password
  • Lost your password
  • Send another code
  • Need help finding your site address

Title color issues checklist

  • Paste tooltip is white text not purple

screen shot 2018-07-11 at 12 23 20 pm

  • Fulfill order button has white text not purple

screen shot 2018-07-13 at 10 47 22 am

@jleandroperez
Copy link
Contributor

@mindgraffiti testing this one. But since the Authenticator PR affects entities that are not in WCiOS, as per the PR description, mind sending a PR in the WPiOS repository so that we can verify the remaining points?

Plus: please, make sure to map the WordPressAuthenticator hash that should be tested. Reasons for doing so are:

  • If the PR was to get accidentally merged, literally nothing would break
  • BuddyBuild won't fail, and the branch should get marked green

You can map a specific commit this way:

pod 'WordPressAuthenticator', :git => 'https://github.com/wordpress-mobile/WordPressAuthenticator-iOS.git', :commit => '162a728'

(Replace with the appropriate hash). Thanks Thuy!!

Copy link
Contributor

@jleandroperez jleandroperez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please feel free to merge this one once the WordPressAuthenticator reference has been updated!! nice work Thuy!!

:shipit:

@mindgraffiti
Copy link
Contributor Author

mind sending a PR in the WPiOS repository so that we can verify the remaining points

yep! It's wordpress-mobile/WordPress-iOS#9766. I'll work on this one this week.

@jleandroperez
Copy link
Contributor

Cool!. We should probably review that one (before merging the Authenticator PR!!) since it really affects the two apps at once.

@mindgraffiti mindgraffiti merged commit f3fc751 into develop Jul 17, 2018
@mindgraffiti mindgraffiti deleted the bugfix/151-subheadline-buttons branch July 17, 2018 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

type: bug A confirmed bug.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants