This repository was archived by the owner on Feb 5, 2025. It is now read-only.
Bump reference to WordPressKit #46
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
suggested changes
Jan 22, 2019
ghost
left a comment
ghost
left a comment
There was a problem hiding this comment.
@ctarda I can confirm that this branch builds and tests pass!
Our discussion of this associated PR, however, suggests that we should reference the revised version of WordPressKit.
Moreover, I believe we also need to update s.version in WordPressAuthenticator.podspec.
ghost
approved these changes
Jan 23, 2019
ghost
left a comment
ghost
left a comment
There was a problem hiding this comment.
Once we publish a new release of WordPressKit, we should be able to update these references, and 
!
# Conflicts: # Podfile.lock
ctarda
force-pushed
the
try/bump-wpkit
branch
from
4a0be3a to
004777f
Compare
ctarda
force-pushed
the
try/bump-wpkit
branch
from
004777f to
88d5a71
Compare
jtreanor
approved these changes
Jan 24, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As part of the implementation of issue #10316 in WordPress-iOS, I found necessary to bump the reference to WordPressKit-iOS