UL&S: Implements re-authentication flow tracking by diegoreymendez · Pull Request #489 · wordpress-mobile/WordPressAuthenticator-iOS · GitHub

This repository was archived by the owner on Feb 5, 2025. It is now read-only.

Contributor

diegoreymendez commented Sep 30, 2020 •

edited

Loading

WPiOS PR: wordpress-mobile/WordPress-iOS#15018

This PR:

Implements the re-authentication flow tracking.
Removed some no-longer-necessary code that was being used to enable tracking based on multiple feature flags.
Fixes the test target for the project, so it's possible to reference Swift code from ObjC.

For testing steps please refer to the WPiOS PR.


          Implements tracking for the re-authentication flow.

69bc15e

diegoreymendez added the enhancement label

diegoreymendez self-assigned this

diegoreymendez mentioned this pull request

UL&S: Implements re-authentication flow tracking. wordpress-mobile/WordPress-iOS#15018

Merged

3 tasks

diegoreymendez commented

View reviewed changes

WordPressAuthenticator/Analytics/AuthenticatorAnalyticsTracker.swift Outdated Show resolved Hide resolved


          Fixes the unit tests.

4e9f224

diegoreymendez commented

View reviewed changes

WordPressAuthenticator.xcodeproj/project.pbxproj Show resolved Hide resolved

diegoreymendez commented

View reviewed changes

WordPressAuthenticator/Analytics/AuthenticatorAnalyticsTracker.swift Show resolved Hide resolved

diegoreymendez commented

View reviewed changes

WordPressAuthenticatorTests/Services/LoginFacadeTests.m Show resolved Hide resolved

diegoreymendez commented

View reviewed changes

WordPressAuthenticatorTests/SupportingFiles/WordPressAuthenticatorTests-Bridging-Header.h Show resolved Hide resolved

diegoreymendez commented

View reviewed changes

WordPressAuthenticator/Authenticator/WordPressAuthenticator.swift Show resolved Hide resolved

diegoreymendez requested review from ScoutHarris and mindgraffiti

September 30, 2020 18:41

diegoreymendez marked this pull request as ready for review

September 30, 2020 18:41

mindgraffiti approved these changes

View reviewed changes

Contributor

mindgraffiti left a comment

Thank you for all the context!

🌟 Generating the bridging header for tests
✅ Code

diegoreymendez added 2 commits

October 1, 2020 17:42


          Merge branch 'develop' into try/implement-reauthentication-source-tra…

80df2bd

…cking


          Updates the podspec version.

0723a8d

diegoreymendez merged commit d5ee139 into develop

diegoreymendez deleted the try/implement-reauthentication-source-tracking branch

October 1, 2020 21:06

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels