Skip to content

Conversation

@diegoreymendez
Copy link
Contributor

@diegoreymendez diegoreymendez commented Sep 30, 2020

WPAuth PR: wordpress-mobile/WordPressAuthenticator-iOS#489

Fixes an issue with tracking during re-authentication.
Implements the re-authentication flow tracking.

Testing:

Test 1:

  1. Log in to a WP.com account
  2. Using the web, disconnect WPiOS. (https://wordpress.com/me/security/connected-applications)
  3. Do something in WPiOS that would trigger a network request.
  4. Once the password screen is up check.

🔵 Tracked: unified_login_step <flow: login_password, source: reauthentication, step: start>

  1. Tap on Help and verify:

🔵 Tracked: unified_login_interaction <click: show_help, flow: login_password, source: reauthentication, step: start>
🔵 Tracked: unified_login_step <flow: login_password, source: reauthentication, step: help>

  1. Tap “Close” and verify:

🔵 Tracked: unified_login_interaction <click: dismiss, flow: login_password, source: reauthentication, step: help>

  1. Enter the correct password, tap “Continue” and verify:

🔵 Tracked: unified_login_interaction <click: submit, flow: login_password, source: reauthentication, step: start>
🔵 Tracked: unified_login_step <flow: login_password, source: reauthentication, step: success>

PR submission checklist:

  • I have considered adding unit tests where possible.
  • I have considered adding accessibility improvements for my changes.
  • I have considered if this change warrants user-facing release notes and have added them to RELEASE-NOTES.txt if necessary.

@diegoreymendez diegoreymendez self-assigned this Sep 30, 2020
@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Sep 30, 2020

You can trigger an installable build for these changes by visiting CircleCI here.

@peril-wordpress-mobile
Copy link

peril-wordpress-mobile bot commented Sep 30, 2020

You can trigger optional UI/connected tests for these changes by visiting CircleCI here.

@diegoreymendez diegoreymendez marked this pull request as ready for review September 30, 2020 18:41
Copy link
Contributor

@mindgraffiti mindgraffiti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ UI tested
✅ Events reported

:shipit:

🔵 Tracked: unified_login_step <flow: login_password, source: reauthentication, step: start>
🔵 Tracked: unified_login_interaction <click: show_help, flow: login_password, source: reauthentication, step: start>
🔵 Tracked: unified_login_step <flow: login_password, source: reauthentication, step: help>
🔵 Tracked: support_opened <>
🔵 Tracked: unified_login_interaction <click: dismiss, flow: login_password, source: reauthentication, step: help>
🔵 Tracked: unified_login_interaction <click: submit, flow: login_password, source: reauthentication, step: start>
🔵 Tracked: unified_login_step <flow: login_password, source: reauthentication, step: 2fa>
🔵 Tracked: unified_login_step <flow: login_password, source: reauthentication, step: success>

@diegoreymendez
Copy link
Contributor Author

Thanks for the reviews @mindgraffiti !

@diegoreymendez diegoreymendez merged commit e455ce2 into develop Oct 2, 2020
@diegoreymendez diegoreymendez deleted the try/implement-reauthentication-source-tracking branch October 2, 2020 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants