-
Notifications
You must be signed in to change notification settings - Fork 1.1k
UL&S: Implements re-authentication flow tracking. #15018
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UL&S: Implements re-authentication flow tracking. #15018
Conversation
|
You can trigger an installable build for these changes by visiting CircleCI here. |
|
You can trigger optional UI/connected tests for these changes by visiting CircleCI here. |
mindgraffiti
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ UI tested
✅ Events reported
![]()
🔵 Tracked: unified_login_step <flow: login_password, source: reauthentication, step: start>
🔵 Tracked: unified_login_interaction <click: show_help, flow: login_password, source: reauthentication, step: start>
🔵 Tracked: unified_login_step <flow: login_password, source: reauthentication, step: help>
🔵 Tracked: support_opened <>
🔵 Tracked: unified_login_interaction <click: dismiss, flow: login_password, source: reauthentication, step: help>
🔵 Tracked: unified_login_interaction <click: submit, flow: login_password, source: reauthentication, step: start>
🔵 Tracked: unified_login_step <flow: login_password, source: reauthentication, step: 2fa>
🔵 Tracked: unified_login_step <flow: login_password, source: reauthentication, step: success>
|
Thanks for the reviews @mindgraffiti ! |
WPAuth PR: wordpress-mobile/WordPressAuthenticator-iOS#489
Fixes an issue with tracking during re-authentication.
Implements the re-authentication flow tracking.
Testing:
Test 1:
🔵 Tracked: unified_login_step <flow: login_password, source: reauthentication, step: start>
🔵 Tracked: unified_login_interaction <click: show_help, flow: login_password, source: reauthentication, step: start>
🔵 Tracked: unified_login_step <flow: login_password, source: reauthentication, step: help>
🔵 Tracked: unified_login_interaction <click: dismiss, flow: login_password, source: reauthentication, step: help>
🔵 Tracked: unified_login_interaction <click: submit, flow: login_password, source: reauthentication, step: start>
🔵 Tracked: unified_login_step <flow: login_password, source: reauthentication, step: success>
PR submission checklist:
RELEASE-NOTES.txtif necessary.