This repository was archived by the owner on Feb 5, 2025. It is now read-only.
Remove 1password framework usage. #629
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ble-code Remove unreachable code related to 1Password
This reverts commit 253361e.
Remove code targeting iOS 12 or lower
…516-remove-1Password
Completely remove 1Password dependency
Contributor
Author
|
Fyi, @hassaansaleh |
frosty
approved these changes
Jan 4, 2022
Contributor
frosty
left a comment
frosty
left a comment
There was a problem hiding this comment.
Code changes look good, and I tested using this branch in WordPress-iOS and everything worked as expected. 
Contributor
|
I tested this as part of My attempt was successful and I didn't notice any difference in the flow 👍
|
Contributor
|
thanks @mokagio! It's not official yet, but the switch is in progress. Thanks tagging both of us! |
1 task
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes wordpress-mobile/WordPress-iOS#17516
This PR completely removes the 1Password dependency from the authenticator and cleans up our code around it. I'm posting this PR but the work was done by @hassaansaleh.
This is a feature branch combining the work of these PRs: #623, #625 and #626.
The changes were done transparently for the App so there are no required changes in WPiOS (or WCiOS).
Testing: