This repository was archived by the owner on Feb 5, 2025. It is now read-only.
Fix CircularImageView so both apps (WooCommerce & WordPress) have a circular image in the password screen #627
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
Contributor
|
PR to test the fix on WC-iOS: woocommerce/woocommerce-ios#5634. |
Contributor
|
@dvdchr the change shouldn't impact WP-iOS, but I would be grateful for another look! It's an interesting bug 🙂 |
Contributor
|
Merging to a temp branch first to apply the latest |
Contributor
|
hey @ealeksandrov, sorry for the late response! I thought I had added this to my things to visit later, but apparently, I did not 😅. I've tested this on WP-iOS and can confirm that it has no impact. Thanks for the heads up and for taking care of this! |
Contributor
|
No worries @dvdchr, thanks for checking! 🙂 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the issue that describes it here.
In the
GravatarEmailTableViewCell.xibfile, theUIImageViewuses aCircularImageViewclass withWordPressas a module.This makes the image circular only in the WordPress app and not in the WooCommerce app.
Changing it to
WordPressAuthanticatormodule will make the image circular in both apps.Screenshots
Before:
After: