Skip to content
This repository was archived by the owner on Feb 5, 2025. It is now read-only.

Conversation

@ealeksandrov
Copy link
Contributor

Related to woocommerce/woocommerce-ios#3366.
Based on #627.

Description

It's a merge conflict fix on top of #627.

In the GravatarEmailTableViewCell.xib file, the UIImageView uses a CircularImageView class with WordPress as a module.
This makes the image circular only in the WordPress app and not in the WooCommerce app.
Changing it to the WordPressAuthenticator module will make the image circular in both apps.

Testing

Instructions can be found in related WC PR: woocommerce/woocommerce-ios#5634.

Screenshots

Before After
before after

johncodeos and others added 4 commits December 7, 2021 18:06
Fix CircularImageView so both apps (WooCommerce & WordPress) have a circular image in the password screen
# Conflicts:
#	WordPressAuthenticator.podspec
#	WordPressAuthenticator/Unified Auth/View Related/Reusable Views/GravatarEmailTableViewCell.xib
@ealeksandrov ealeksandrov added the bug Something isn't working label Feb 3, 2022
@itsmeichigo itsmeichigo self-assigned this Feb 15, 2022
Copy link
Contributor

@itsmeichigo itsmeichigo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

@ealeksandrov ealeksandrov merged commit 2d3804b into trunk Feb 15, 2022
@ealeksandrov ealeksandrov deleted the fix/circular-imageview branch February 15, 2022 06:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants