[Login- "Continue with WordPress.com" flow] - Add What is WordPress.com? button. #646
Conversation
… resizing table view header and footer views.
jaclync
left a comment
jaclync
left a comment
There was a problem hiding this comment.
Nice work @selanthiraiyan navigating through the authenticator codebase and coming up with the changes so quickly! 💯
One thing I'd like to confirm is the design: is there a reference for the design with the underscored link? I couldn't seem to find it in the design post pe5sF9-1U-p2
WordPressAuthenticator/Authenticator/WordPressAuthenticatorConfiguration.swift
Outdated
Show resolved
Hide resolved
WordPressAuthenticator/Extensions/UITableView+HeaderFooterHelpers.swift
Outdated
Show resolved
Hide resolved
WordPressAuthenticator/Unified Auth/View Related/Get Started/GetStartedViewController.swift
Show resolved
Hide resolved
|
|
||
| /// Tracked when the user clicks “What is WordPress.com?" button on the WordPress.com flow screen | ||
| /// | ||
| case whatIsWpCom = "what_is_wordpress_com" |
There was a problem hiding this comment.
super nit: it'd be nice having a consistent naming convention
| case whatIsWpCom = "what_is_wordpress_com" | |
| case whatIsWPCom = "what_is_wordpress_com" |
There was a problem hiding this comment.
It might be worth confirming with WPiOS about adding a new event to the analytics tracker, I'm not super sure if they have a workflow for analytics like whether they keep track of all the events. @pmusolino do you know who we can reach out for taking a look at this, after the recent team changes in WPiOS? (I saw that a bunch of the authors aren't with WPiOS anymore)
There was a problem hiding this comment.
super nit: it'd be nice having a consistent naming convention
Done in 48fbd17
There was a problem hiding this comment.
It might be worth confirming with WPiOS about adding a new event to the analytics tracker, I'm not super sure if they have a workflow for analytics like whether they keep track of all the events. @pmusolino do you know who we can reach out for taking a look at this, after the recent team changes in WPiOS? (I saw that a bunch of the authors aren't with WPiOS anymore)
I haven't had success with building https://github.com/wordpress-mobile/WordPress-iOS app. I will try to build again and validate this.
There was a problem hiding this comment.
I have raised a PR in WP iOS wordpress-mobile/WordPress-iOS#18996 to test this.
I have also validated that the changes related to the analytics tracker are non-breaking.
There was a problem hiding this comment.
Yea I don't think the change affects WPiOS, but just wanted to see if they have a centralized doc to keep track of the events
|
Hey @selanthiraiyan do you know if we have the design confirmed? Just wanted to check first since it probably takes more time to release another pod version than making any design changes again 😅 If we don't have a design reference yet, I can ask in the design requests today and hopefully hear back tomorrow.
|
|
@jaclync Oh, I forgot about the question about design. Sorry. 🙏 I confirmed with the design team in slack and got approval for this design. You can check the thread here p1657014068195729/1656997606.750839-slack-C03L1NF1EA3 |
jaclync
left a comment
jaclync
left a comment
There was a problem hiding this comment.
LGTM, nice work @selanthiraiyan ! 
Thanks for verifying the design, I added the reference to the PR description. There are so many conversations on various platforms these days 😅
Tested with large font sizes, and the new event is tracked in the console 👍
Related to woocommerce/woocommerce-ios#7212
Design ref: p1657014068195729/1656997606.750839-slack-C03L1NF1EA3
Description
This PR adds
What is WordPress.com?button in the Email entry screen of "Continue with WordPress.com" flow.As we cannot expect all users who install the app to be familiar with "WordPress.com" we are adding this button to teach users about "WordPress.com".
This is part of "Experiment 2: Add more information about the login process" in pe5sF9-6C-p2
Testing instructions
Check out the branch from woocommerce/woocommerce-ios#7213 and follow the testing instructions specified in the PR.
Screenshots