This repository was archived by the owner on Feb 5, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 11
[Login- "Continue with WordPress.com" flow] - Add What is WordPress.com? button. #646
Merged
Merged
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
7009d36
Bring `UITableView+HeaderFooterHelpers` from WooCommerce iOS repo for…
selanthiraiyan fe71c89
Add analytics event to cover what is WordPress.com link tap event.
selanthiraiyan e225dde
Add `whatIsWPComURL` string to hold "What is WordPress.com" webpage URL.
selanthiraiyan 7c08bdf
Add `whatIsWPComLinkTitle` to hold the title for "What is WordPress.c…
selanthiraiyan 5b59f4f
Add helper method for creating for "What is WordPress.com" link button.
selanthiraiyan 6fdbbdd
Use stack view for adding `Continue` button and stop hardcoding the h…
selanthiraiyan 1358cfc
Add "What is WordPress.com" button.
selanthiraiyan fade30c
Bumping beta version to `2.0.1-beta.1`
selanthiraiyan f1f7a2e
Update footer height on layout subviews call.
selanthiraiyan 36ded4a
Mention that the button will be displayed if the value is `nil`.
selanthiraiyan 4b36045
Add only `updateFooterHeight` method to `UITableView+Helpers` and re…
selanthiraiyan 48fbd17
Replace `WpCom` with `WPCom` for consistent naming.
selanthiraiyan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
20 changes: 20 additions & 0 deletions
20
WordPressAuthenticator/Extensions/UITableView+Helpers.swift
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| import UIKit | ||
|
|
||
| extension UITableView { | ||
| /// Called in view controller's `viewDidLayoutSubviews`. If table view has a footer view, calculates the new height. | ||
| /// If new height is different from current height, updates the footer view with the new height and reassigns the table footer view. | ||
| /// Note: make sure the top-level footer view (`tableView.tableFooterView`) is frame based as a container of the Auto Layout based subview. | ||
| func updateFooterHeight() { | ||
| if let footerView = tableFooterView { | ||
| let targetSize = CGSize(width: footerView.frame.width, height: 0) | ||
| let newSize = footerView.systemLayoutSizeFitting(targetSize, withHorizontalFittingPriority: .required, verticalFittingPriority: .defaultLow) | ||
| let newHeight = newSize.height | ||
| var currentFrame = footerView.frame | ||
| if newHeight != currentFrame.size.height { | ||
| currentFrame.size.height = newHeight | ||
| footerView.frame = currentFrame | ||
| tableFooterView = footerView | ||
| } | ||
| } | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.