Skip to content
This repository was archived by the owner on Feb 5, 2025. It is now read-only.

Conversation

@selanthiraiyan
Copy link
Contributor

@selanthiraiyan selanthiraiyan commented Aug 10, 2022

For woocommerce/woocommerce-ios#7444

Description

In the sign-in with site credentials flow, in the Site credentials screen, if I enter an incorrect password, the username and password fields are emptied/cleared. This doesn't leave a chance for the user to edit and fix types.

This PR attempts to stop clearing the username and password when an error occurs.

Testing steps

Please refer to the relating WCiOS PR to test the integration.

@selanthiraiyan selanthiraiyan changed the title [Sign in with site credentials] Don't clear username/password on error. [Sign in with site credentials] - Don't clear username and password after an invalid login attempt. Aug 10, 2022
@selanthiraiyan selanthiraiyan marked this pull request as ready for review August 10, 2022 12:01
@itsmeichigo itsmeichigo self-assigned this Aug 11, 2022
Copy link
Contributor

@itsmeichigo itsmeichigo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@selanthiraiyan selanthiraiyan merged commit ac1d4e8 into trunk Aug 11, 2022
@selanthiraiyan selanthiraiyan deleted the wcios/dontClearSiteCredentials branch August 11, 2022 04:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants