Skip to content
This repository was archived by the owner on Feb 5, 2025. It is now read-only.

[Sign in with site credentials] - Don't clear username and password after an invalid login attempt. #663

Merged
merged 6 commits into from
Aug 11, 2022
Merged

[Sign in with site credentials] - Don't clear username and password after an invalid login attempt. #663

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
e86870a
Clean up textfield cell's style in prepareForReuse.
selanthiraiyan Aug 10, 2022
1a74b9c
Configure username from `loginFields` to show username on tableview r…
selanthiraiyan Aug 10, 2022
d73a829
Configure password from `loginFields` to show password on tableview r…
selanthiraiyan Aug 10, 2022
4c1f68b
Bump pod spec version.
selanthiraiyan Aug 10, 2022
f2f89c9
Revert "Bump pod spec version."
selanthiraiyan Aug 10, 2022
440fc37
Bump pod spec beta version.
selanthiraiyan Aug 10, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion WordPressAuthenticator.podspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

Pod::Spec.new do |s|
s.name = 'WordPressAuthenticator'
s.version = '2.2.0-beta.2'
s.version = '2.2.0-beta.3'

s.summary = 'WordPressAuthenticator implements an easy and elegant way to authenticate your WordPress Apps.'
s.description = <<-DESC
Expand Down
6 changes: 6 additions & 0 deletions WordPressAuthenticator/Unified Auth/View Related/Reusable Views/TextFieldTableViewCell.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,13 @@ final class TextFieldTableViewCell: UITableViewCell {
override func prepareForReuse() {
super.prepareForReuse()

textField.keyboardType = .default
textField.returnKeyType = .default
setSecureTextEntry(false)
showSecureTextEntryToggle = false
textField.rightView = nil
textField.accessibilityLabel = nil
textField.accessibilityIdentifier = nil
}
}

Expand Down
6 changes: 4 additions & 2 deletions ...sAuthenticator/Unified Auth/View Related/Site Address/SiteCredentialsViewController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -280,7 +280,8 @@ private extension SiteCredentialsViewController {
///
func configureUsernameTextField(_ cell: TextFieldTableViewCell) {
cell.configure(withStyle: .username,
placeholder: WordPressAuthenticator.shared.displayStrings.usernamePlaceholder)
placeholder: WordPressAuthenticator.shared.displayStrings.usernamePlaceholder,
text: loginFields.username)

// Save a reference to the textField so it can becomeFirstResponder.
usernameField = cell.textField
Expand All @@ -302,7 +303,8 @@ private extension SiteCredentialsViewController {
///
func configurePasswordTextField(_ cell: TextFieldTableViewCell) {
cell.configure(withStyle: .password,
placeholder: WordPressAuthenticator.shared.displayStrings.passwordPlaceholder)
placeholder: WordPressAuthenticator.shared.displayStrings.passwordPlaceholder,
text: loginFields.password)
passwordField = cell.textField
cell.textField.delegate = self
cell.onChangeSelectionHandler = { [weak self] textfield in
Expand Down