This repository was archived by the owner on Feb 5, 2025. It is now read-only.
Make WordPress.com URLs configurable through WordPressAuthenticatorConfiguration #93
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkmassel
approved these changes
May 8, 2019
Contributor
jkmassel
left a comment
jkmassel
left a comment
There was a problem hiding this comment.
✅ Code looks good
✅ Unit Tests Pass
✅ WPiOS Branch Compiles + Runs
✅ Login Flow Worked in smoke test
✅ 
Contributor
Author
|
Thanks for the quick review @jkmassel! 🎉 |
This was referenced May 9, 2019
1 task
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I recently made changes to WordPressKit to allow WP.com urls to be configured for testing purposes (wordpress-mobile/WordPressKit-iOS#141). This is the corresponding changes to WordPressAuthenticator to take advantage of that.
I have added two new items to
WordPressAuthenticatorConfiguration:wpcomBaseURLandwpcomAPIBaseURL. They default to the correct values so that existing installations will not break.I have also updated the
.podspecversion since this includes API changes.Testing Details
All tests pass and the podspec validates.
(Optional) Check out my corresponding WPiOS branch (
try/configure-base-urls) and do a smoke test of the login flow. Draft PR is here: Allow WordPress.com API URLs to be overridden with a launch argument WordPress-iOS#11655.Please check here if your pull request includes additional test coverage.