This repository was archived by the owner on Feb 5, 2025. It is now read-only.
Use wpcomAPIBaseURL in all WordPressComRestApi instances #96
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkmassel
approved these changes
May 17, 2019
Contributor
jkmassel
left a comment
jkmassel
left a comment
There was a problem hiding this comment.
I left one optional suggestion, but apart from that:
✅ Code compiles
✅ Tests pass
✅ Code changes look sensible
✅ 
| private func checkEmailAvailability(completion:@escaping (Bool) -> ()) { | ||
|
|
||
| let remote = AccountServiceRemoteREST(wordPressComRestApi: WordPressComRestApi()) | ||
| let remote = AccountServiceRemoteREST(wordPressComRestApi: WordPressComRestApi(baseUrlString: WordPressAuthenticator.shared.configuration.wpcomAPIBaseURL)) |
Contributor
There was a problem hiding this comment.
I don't think we enforce it on this repo, but this line is rather long – could probably be broken up into smaller statements to be a bit more understandable?
Up to you :)
1 task
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As I have been developing networking mocking, I have discovered a few places that the WP.com API URL needs to be injected which I missed in #93.
This PR makes sure every instance of
WordPressComRestApiin WordPressAutheticator uses the injectablewpcomAPIBaseURL.