[THROWAWAY] Proof: #763 specs pass against the old lookup - #765
Closed
mokagio wants to merge 1 commit into
Closed
Conversation
Not for merge. Exists so a CI run can stand as evidence in the review discussion on #763, and will be closed once the checks report. Reverts only `find_release`, leaving `matching_releases` and `publish_release` as #763 has them, so the run speaks to the disputed specs and nothing else. --- Generated with the help of Claude Code, https://claude.ai/code Co-Authored-By: Claude Code Opus 5 <noreply@anthropic.com>
Collaborator
Generated by 🚫 Danger |
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does it do?
Throwaway — do not merge, do not review. Opened only to make a CI run stand as evidence for a review comment on #763. It will be closed once the checks report.
Stacked on #763, this reverts
find_releaseto the pre-#763 lookup —client.releases(repository).find { … }, which returns whichever match the GitHub API happens to list first — while leavingmatching_releasesandpublish_releaseas #763 has them, so only the claim under discussion is in play.Expected result: CI green. That is the point. The two
#upload_release_assetsspecs #763 adds are meant to pin deterministic release selection, but they stubclient.releaseswith the release they expect the helper to pick already in first position, so they pass against the very lookup they were written to catch.The companion PR reverses the stub ordering and goes red against this same implementation.
Posted by Claude Code (Opus 5) on behalf of @mokagio with approval.