Copy over everything from web-components#68
Conversation
cd7b00d to
3715350
Compare
|
@nathanleclaire ok, this is very ready for review&merge |
|
mmm, yeah, i'm going to need you to tell me about the config serialisation - I'm confused why this compiles, considering i've removed the WBAccount type definition :/ |
|
|
||
| const HEXDUMP_BYTES = 512; | ||
|
|
||
| // TODO: make a gloabal state of "current slot number" |
There was a problem hiding this comment.
i need this for transaction following (which I think I want to make replace program changes) as well
|
Whew! Massive PR! Nicely done, I really like the Airdrop/Transfer buttons and I think web workbench is going to be huge. We need to start making a list of what's broken now (hell, even |
edit: Ah OK this is odd. Looking into it... |
|
So isn't using localStorage for accounts going to blow away all the users' stateful stuff when they update the Electron app? We'll fix that in our follow-up(s) to make the tool backend agnostic I guess? |
|
You're using Microsoft ESLint plugin right? |
|
I need my cli build tooling to at minimum have the errors and warnings the editor shows - in this PR's case, I basically missed the main issues because i didn't open them - I was expecting (really stupidly) that the |
5f38d3c to
f52ff1d
Compare
|
Alright I suspect you will get these CI errors ironed out soon, if you get the green today ahead and merge, if not, give it a second and I'll look at them in AM to see if I can help troubleshoot! LGTM once |
|
half way through re-making the config slice on the render side - its close, but not complete - tomorrow! |
|
ok, what remains needs more careful work - they're all because I moved all the account selection state info to client side state only using localStorage, and we need to work out a good time, place and method for pushing that back to the main loop I kinda wonder if the json file creation maybe should happen client side too - so the web version can allow the user to download the json file to give solana - but its 10pm, so i'll bunt to tomorrow :D and by god this is so much easier when you know you need all three commands |
|
REBASING - squashing first, cos rebasing 52 times is horrible |
3aa04e0 to
148da1b
Compare
|
wow, so so another command that can trip you up, even when |
Signed-off-by: Sven Dowideit <SvenDowideit@home.org.au>
…l fix it in this PR, or the next Signed-off-by: Sven Dowideit <SvenDowideit@home.org.au>
148da1b to
1243bed
Compare
|
I think you need to do Not much we can do about errors on run/package if the correct modules haven't been installed. LGTM |


so this is just a copy of the web-components code.
(The only difference in the first commit is the BrowserRouter to HashRouter change in index.tsx)
This PR upgrades to
react-routerv6, uses local storage for user data (for the web-app, i'm thinking we can sync that to a server based on a solana account / wallet identity)I need to bring back:
7 problems (0 errors, 7 warnings)Some of these may be a follow on PR...