Yell about TypeScript errors more aggressively

[nathanleclaire]

Fixes #75

[nathanleclaire]

This was a weird one, originally I had to add these to get TS compiler to stop complaining that types couldn't be found for these modules, but then it started complaining again for some reason despite the existence of this file when I removed the transpile only false settings. 🤷

It works and we're looking to rm these modules anyway so I'm rolling with the switch to require for now

[nathanleclaire]

Bleh, these changes are more far-reaching than I intended, sorry. npm install --save-dev for a new @types file that the CI was breaking due to not having ended up making all these changes.

[SvenDowideit]

lets see what docker build . does for me:

Step 12/17 : RUN source /root/.profile && source $HOME/.nvm/nvm.sh     && npm install --legacy-peer-deps
 ---> Running in 06c6c8231ddd



npm WARN deprecated circular-json@0.5.9: CircularJSON is in maintenance only, flatted is its successor.
npm WARN deprecated crypto@0.0.3: This package is no longer supported. It's now a built-in Node module. If you've depended on crypto, you should switch to the one that's built-in.
npm WARN deprecated source-map-resolve@0.6.0: See https://github.com/lydell/source-map-resolve#deprecated
npm WARN deprecated @types/terser-webpack-plugin@5.2.0: This is a stub types definition. terser-webpack-plugin provides its own type definitions, so you do not need this installed.
npm notice 
npm notice New minor version of npm available! 8.3.1 -> 8.6.0
npm notice Changelog: <https://github.com/npm/cli/releases/tag/v8.6.0>
npm notice Run `npm install -g npm@8.6.0` to update!
npm notice 
npm ERR! code ERR_SOCKET_TIMEOUT
npm ERR! network Socket timeout
npm ERR! network This is a problem related to network connectivity.
npm ERR! network In most cases you are behind a proxy or have bad network settings.
npm ERR! network 
npm ERR! network If you are behind a proxy, please make sure that the
npm ERR! network 'proxy' config is set properly.  See: 'npm help config'

npm ERR! A complete log of this run can be found in:
npm ERR!     /root/.npm/_logs/2022-04-06T01_14_53_592Z-debug-0.log

ok, now to try again on my local box.

[SvenDowideit]

ok, succeeds on local new clone - so its something-something out of sync (DEFER fixing that)

[SvenDowideit]

ok, so the expected effect is that the npm exec tsc errors will now also be shown in npm start - no change to npm run lint.

Hopefully there's a way to make them also surface in npm run build (it doesn't seem to happen for me atm)

LGTM

[SvenDowideit]

LGTM!