library: Add libportal screenshot entry #208

SoNiC-HeRE · 2023-03-05T20:10:09Z

Added Screenshot Demo in a new section Portal under Library
Issue workbenchdev/demos#3

sonnyp · 2023-03-13T00:16:56Z

So this is working fine for me but

Gdk-Critical: gdk_wayland_toplevel_export_handle: assertion '!wayland_toplevel->xdg_exported' failed

For @SoNiC-HeRE - on the same OS (Fedora 37) - I'm investigating what it could be.

Allows for split view and navigating entries easily

SoNiC-HeRE · 2023-03-20T15:20:13Z

The error has been resolved but when i click the button nothing happens

sonnyp · 2023-05-28T09:39:00Z

@SoNiC-HeRE I merged main into this branch. Could you check once more if this still doesn't work for you?

Perhaps check Workbench permissions

SoNiC-HeRE · 2023-05-28T10:37:43Z

Sure, I'll check again

SoNiC-HeRE · 2023-05-28T11:11:53Z

@SoNiC-HeRE I merged main into this branch. Could you check once more if this still doesn't work for you?

Perhaps check Workbench permissions

Works fine now, had to install it seperately to check, probably was missing some sort of permission when run directly from builder

sonnyp

2 more things

Please use Gio._promisify

Can you check if you get an error if the permission is denied? If so we can display a message using Adw.MessageDialog telling the user how to fix it (I'll let you come up with a clear and concise sentence).

sonnyp · 2023-05-28T11:16:14Z

src/Library/demos/Screenshot/main.js

+const { GdkPixbuf, Gio, GLib, GObject, Gst, Gtk, Pango, PangoCairo } =
+  imports.gi;


please use import x from y

sonnyp · 2023-05-28T11:18:02Z

src/Library/Library.blp

+     Adw.PreferencesGroup library_portal {
+      title: "User Interface";
+    }
+


maybe

Suggested change

Adw.PreferencesGroup library_portal {

title: "User Interface";

}

Adw.PreferencesGroup library_desktop {

title: "Desktop APIs";

}

we can move Notifications there later

Actually, even better (but it's mobile too)

Suggested change

Adw.PreferencesGroup library_portal {

title: "User Interface";

}

Adw.PreferencesGroup library_platform {

title: "Platform APIs";

}

sonnyp · 2023-05-28T11:18:46Z

src/Library/demos/Screenshot/main.blp

+
+Adw.StatusPage {
+  title: "Screenshot";
+  description: _("Keep a snapshot of your current screen");


It should address the developer, not the end user.

Suggested change

description: _("Keep a snapshot of your current screen");

description: _("Take a picture of the screen");

sonnyp · 2023-05-28T11:21:52Z

src/Library/demos/Screenshot/main.blp

+
+    Button Screenshot {
+      icon-name: "camera";
+      margin-bottom: 40;


please use multiples of 6

Suggested change

margin-bottom: 40;

margin-bottom: 42;

sonnyp · 2023-05-28T11:22:36Z

src/Library/demos/Screenshot/main.blp

+
+    LinkButton {
+      label: "API Reference";
+      uri: "https://libportal.org/";


Suggested change

uri: "https://libportal.org/";

uri: "https://libportal.org/method.Portal.take_screenshot.html";

sonnyp · 2023-05-28T11:28:38Z

src/Library/demos/Screenshot/main.js

+  });
+}
+
+Screenshot.connect("clicked", _takeScreenshot);


Suggested change

Screenshot.connect("clicked", _takeScreenshot);

button.connect("clicked", takeScreenshot);

sonnyp · 2023-05-28T11:29:34Z

src/Library/demos/Screenshot/main.json

+{
+  "name": "Screenshot",
+  "category": "portal",
+  "description": "Keep a snapshot of your current screen",


Suggested change

"description": "Keep a snapshot of your current screen",

"description": "Take a picture of the screen",

sonnyp · 2023-05-28T11:29:48Z

src/Library/demos/Screenshot/main.json

@@ -0,0 +1,10 @@
+{
+  "name": "Screenshot",
+  "category": "portal",


Suggested change

"category": "portal",

"category": "desktop",

sonnyp · 2023-05-28T11:30:04Z

src/Library/demos/Screenshot/main.json

+  "category": "portal",
+  "description": "Keep a snapshot of your current screen",
+  "panels": [
+    "ui",


Suggested change

"ui",

"code",

it's more important here

sonnyp · 2023-05-28T11:33:47Z

src/Library/demos/Screenshot/main.js

+      const pixbuf = GdkPixbuf.Pixbuf.new_from_file_at_scale(
+        path,
+        60,
+        40,
+        true,
+      );
+      workbench.builder.get_object("picture").set_pixbuf(pixbuf);


hehe thankefully we don't need pixbuf and scale to arbitrary dimensions (which don't work equally well for differentt display rattios)

take_screenshot gives us a file:/// uri, which we can use to load the file directly into Picture

const uri = ... const file = Gio.File.new_for_uri(uri); picture.set_file(file);

SoNiC-HeRE · 2023-05-29T16:05:01Z

@sonnyp The portal methods doesnt seem to work properly with GIO's async methods. Tried implementing without using Gio._promisify

Also i thought It'd be better if we could directly log the error message instead of Adw.messagedialog wdyt?

sonnyp · 2023-05-29T18:05:14Z

The portal methods doesnt seem to work properly with GIO's async methods

What is the error? What's not working? I can take a look.

Also i thought It'd be better if we could directly log the error message instead of Adw.messagedialog wdyt?

The MessageDialog is not for showing the error, it's to tell the user what to do if the permission is/was denied.

If error is permission denied: show a MessageDialog to tel the user what todo
If error is not permission denied: logError

SoNiC-HeRE · 2023-05-29T21:20:05Z

The portal methods doesnt seem to work properly with GIO's async methods

What is the error? What's not working? I can take a look.

Also i thought It'd be better if we could directly log the error message instead of Adw.messagedialog wdyt?

The MessageDialog is not for showing the error, it's to tell the user what to do if the permission is/was denied.

If error is permission denied: show a MessageDialog to tel the user what todo If error is not permission denied: logError

I'll try fixing again , if not i'll share

This reverts commit 03695f8.

SoNiC-HeRE · 2023-05-30T01:18:08Z

All of the above mentioned changes have been implemented. Implemented with Async method as well but works fine even without it. Thought code would be shorter and cleaner.

sonnyp

Good error handling 👍

An issue I noticed while testing the demo is that the size and position of elements change once the screenshot is taken and displayed. It doesn't feel great.

I have fixed that, made promisify work and address the last comments in this commit: 0f22390

Please fetch Workbench main and look at my changes and the result.

sonnyp · 2023-05-30T09:24:48Z

src/Library/demos/Screenshot/main.blp

+      icon-name: "screenshooter-symbolic";
+      margin-bottom: 42;
+      width-request: 6;
+      height-request: 48;


We shouldn't override stanard elements default allocation (size).

Also, I think a label button would be clearer. No need for small icon button.

sonnyp · 2023-05-30T09:25:09Z

src/Library/demos/Screenshot/main.js

+const portal = new Xdp.Portal();
+const parent = XdpGtk.parent_new_gtk(workbench.window);
+const picture = workbench.builder.get_object("picture");
+const window = button.get_ancestor(Gtk.Window);


that's workbench.window

sonnyp · 2023-05-30T09:25:21Z

src/Library/demos/Screenshot/main.js

+const button = workbench.builder.get_object("button");
+const portal = new Xdp.Portal();
+const parent = XdpGtk.parent_new_gtk(workbench.window);
+const picture = workbench.builder.get_object("picture");
+const window = button.get_ancestor(Gtk.Window);


try to group things that make sense together

sonnyp · 2023-05-30T09:25:55Z

src/Library/demos/Screenshot/main.js

+      picture.width_request = 180;
+      picture.height_request = 180;


Please remember to use properties in Bluepint when possible

SoNiC-HeRE · 2023-05-30T14:15:56Z

Good error handling +1

An issue I noticed while testing the demo is that the size and position of elements change once the screenshot is taken and displayed. It doesn't feel great.

I have fixed that, made promisify work and address the last comments in this commit: 0f22390

Please fetch Workbench main and look at my changes and the result.

Sure, I'll have a look

Added Screenshot Demo using Libportal

098c946

SoNiC-HeRE marked this pull request as draft March 5, 2023 20:11

SoNiC-HeRE marked this pull request as ready for review March 5, 2023 20:11

SoNiC-HeRE marked this pull request as draft March 5, 2023 20:14

sonnyp added the Library 📚️ label Mar 6, 2023

sonnyp added 2 commits March 7, 2023 00:22

Merge branch 'main' into Screenshot

a9adf94

fix

147ded9

sonnyp changed the title ~~Added Screenshot Demo using Libportal~~ library: Add libportal screenshot entry Mar 6, 2023

sonnyp self-requested a review March 11, 2023 22:59

sonnyp self-assigned this Mar 11, 2023

AkshayWarrier and others added 11 commits March 13, 2023 14:27

library: Add Avatar entry (workbenchdev#197)

cf745ff

Make Library window non modal (workbenchdev#201)

6748bee

Allows for split view and navigating entries easily

library: Add Text Colors demo (workbenchdev#206)

503f168

Fix typo "Information about Blueprint" (workbenchdev#212)

2653fd4

library: Add Scale entry (workbenchdev#204)

146647a

Use org.gnome.Sdk//44

541117e

Improve contributing guide

74b72b7

Use css_classes property and add_css_class method

f1c9b61

Fix mechanism to return on UI syntax conversion error

d9f1389

Library: Add Dialogs entry (workbenchdev#211)

21ffd6d

Merge branch 'main' into Screenshot

0e59349

sonnyp force-pushed the main branch 3 times, most recently from 05f69f1 to 55e450f Compare May 21, 2023 10:37

Merge branch 'main' into Screenshot

385b80d

sonnyp assigned SoNiC-HeRE and unassigned sonnyp May 28, 2023

sonnyp requested changes May 28, 2023

View reviewed changes

SoNiC-HeRE and others added 3 commits May 28, 2023 19:34

Merge branch 'sonnyp:main' into Screenshot

d8be3b1

Updated code and improved UI

fd8dd03

Updated JS Code

b92d7cd

SoNiC-HeRE marked this pull request as ready for review May 29, 2023 16:02

SoNiC-HeRE added 4 commits May 30, 2023 05:46

Improved JS Code and applied changes

88a6568

Improved Code

03695f8

Revert "Improved Code"

bd93406

This reverts commit 03695f8.

Minor Fixes

8d438a4

Improvements

0f22390

sonnyp approved these changes May 30, 2023

View reviewed changes

sonnyp merged commit 62cc7ac into workbenchdev:main May 30, 2023

sonnyp pushed a commit to krlade/Workbench that referenced this pull request Jun 3, 2023

library: Add libportal screenshot entry (workbenchdev#208)

3b7956c

		const { GdkPixbuf, Gio, GLib, GObject, Gst, Gtk, Pango, PangoCairo } =
		imports.gi;

	description: _("Keep a snapshot of your current screen");
	description: _("Take a picture of the screen");

	uri: "https://libportal.org/";
	uri: "https://libportal.org/method.Portal.take_screenshot.html";

	Screenshot.connect("clicked", _takeScreenshot);
	button.connect("clicked", takeScreenshot);

	"description": "Keep a snapshot of your current screen",
	"description": "Take a picture of the screen",

Uh oh!

library: Add libportal screenshot entry #208

library: Add libportal screenshot entry #208

Uh oh!

Conversation

SoNiC-HeRE commented Mar 5, 2023

Uh oh!

sonnyp commented Mar 13, 2023

Uh oh!

SoNiC-HeRE commented Mar 20, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sonnyp commented May 28, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

SoNiC-HeRE commented May 28, 2023

Uh oh!

SoNiC-HeRE commented May 28, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sonnyp left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

SoNiC-HeRE commented May 29, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

sonnyp commented May 29, 2023

Uh oh!

SoNiC-HeRE commented May 29, 2023

Uh oh!

SoNiC-HeRE commented May 30, 2023

Uh oh!

sonnyp left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

SoNiC-HeRE commented May 30, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

SoNiC-HeRE commented Mar 20, 2023 •

edited

Loading

sonnyp commented May 28, 2023 •

edited

Loading

SoNiC-HeRE commented May 28, 2023 •

edited

Loading

sonnyp left a comment •

edited

Loading

SoNiC-HeRE commented May 29, 2023 •

edited

Loading