Manuals: Sync sidebar without collapsing rows #691
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sonnyp
reviewed
Oct 21, 2023
Contributor
Can you file an issue? It's worth keeping track of. |
Contributor
Let's put it in the menu instead when we have one. Context menu are less and less used due to mobile. |
sonnyp
approved these changes
Oct 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Taking the suggestion from #682 (comment)
With this, the sidebar will be synced without the need to collapse all the rows and reset the sidebar's state. As a follow-up, I could add a context menu (was having bit trouble with this) to give the user an option to collapse all the rows.
Unrelated to this change but, I have also noticed this bug where sometimes selecting an item in the search view for the first time, selects the correct item in browse view but when going back switches to selecting the 1st item ("Adw-1"), not sure why.