Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .last-synced-sha
Original file line number Diff line number Diff line change
@@ -1 +1 @@
55568c6c3f680a6022e29ec48b4c0b8785a21370
de8dbc503fd3555b52628db8a44d4b8b8b304604
15 changes: 10 additions & 5 deletions spec/open-api-spec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -35688,6 +35688,7 @@ components:
enum:
- oauth
- api_key
- client_credentials

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Create request rejects new method

When a client creates a Data Integration using client_credentials, POST /data-integrations consumes CreateDataIntegrationDto, whose auth_methods enum still permits only oauth and api_key, causing generated clients and OpenAPI validators to reject a method that the response contract now advertises as supported.

Prompt To Fix With AI
This is a comment left during a code review.
Path: spec/open-api-spec.yaml
Line: 35691

Comment:
**Create request rejects new method**

When a client creates a Data Integration using `client_credentials`, POST `/data-integrations` consumes `CreateDataIntegrationDto`, whose `auth_methods` enum still permits only `oauth` and `api_key`, causing generated clients and OpenAPI validators to reject a method that the response contract now advertises as supported.

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

description: >-
How accounts authenticate with the provider for this Data
Integration.
Expand Down Expand Up @@ -36202,9 +36203,10 @@ components:
enum:
- oauth
- api_key
- client_credentials
description: >-
The authentication method used for this connection (`oauth` or
`api_key`). Defaults to `oauth` if absent.
The authentication method used for this connection (`oauth`,
`api_key`, or `client_credentials`). Defaults to `oauth` if absent.
example: oauth
api_key_last_4:
type:
Expand Down Expand Up @@ -36312,10 +36314,11 @@ components:
enum:
- oauth
- api_key
- client_credentials
description: >-
The authentication methods supported by this provider
(`oauth`, `api_key`, or both). Defaults to `["oauth"]` if
absent.
(`oauth`, `api_key`, `client_credentials`, or a combination).
Defaults to `["oauth"]` if absent.
example:
- oauth
ownership:
Expand Down Expand Up @@ -36394,9 +36397,11 @@ components:
enum:
- oauth
- api_key
- client_credentials
description: >-
The authentication method used for this connection
(`oauth` or `api_key`). Defaults to `oauth` if absent.
(`oauth`, `api_key`, or `client_credentials`).
Defaults to `oauth` if absent.
example: oauth
api_key_last_4:
type:
Expand Down
Loading