Add WorkOS::Portal.list_organizations#48
Merged
willmanduffy merged 1 commit intomasterfrom Sep 11, 2020
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #48 +/- ##
==========================================
+ Coverage 98.87% 98.95% +0.07%
==========================================
Files 13 15 +2
Lines 267 287 +20
==========================================
+ Hits 264 284 +20
Misses 3 3
Continue to review full report at Codecov.
|
willmanduffy
commented
Sep 9, 2020
| # so we're using Sorbet throughout this Ruby gem. | ||
| module Types | ||
| require_relative 'types/connection_struct' | ||
| require_relative 'types/list_struct' |
Contributor
Author
There was a problem hiding this comment.
This really threw me though a loop and lost a couple hours to finding this...
Thoughts on pulling require_all?
Contributor
Author
There was a problem hiding this comment.
Will follow up with this in a future PR to avoid merge conflicts.
| expect(Net::HTTP::Get).to receive(:new).with(*request_args). | ||
| and_return(expected_request) | ||
|
|
||
| VCR.use_cassette 'organization/list', match_requests_on: [:path] do |
Contributor
Author
There was a problem hiding this comment.
I decided to use the same cassette for all the tests since the response is handled the same regardless. What we really want to test is the request we are sending out and trusting the API will Do The Right Thing™. expected_request is the real test in these option tests.
willmanduffy
force-pushed
the
feature/ch3022/add-list-organizations-method-to-ruby-sdk
branch
from
0f780b5 to
8d88e37
Compare
* Returns a list of the organizations accessible to the provided API key. Includes pagination functionality via the list_metadata property.
willmanduffy
force-pushed
the
feature/ch3022/add-list-organizations-method-to-ruby-sdk
branch
from
8d88e37 to
0bdf5aa
Compare
willmanduffy
changed the title
Contributor
Author
|
@marktran @maxchehab This has been updated with the new naming we outlined in our call today. |
marktran
approved these changes
Sep 11, 2020
willmanduffy
deleted the
feature/ch3022/add-list-organizations-method-to-ruby-sdk
branch
willmanduffy
added a commit
that referenced
this pull request
Sep 14, 2020
* Resolves a hidden step needed before adding a file to the types folder that can be confusing for developers new to the SDK codebase. * Discussion here: #48 (comment)
willmanduffy
added a commit
that referenced
this pull request
Sep 14, 2020
* Resolves a hidden step needed before adding a file to the types folder that can be confusing for developers new to the SDK codebase. * Discussion here: #48 (comment)
willmanduffy
added a commit
that referenced
this pull request
Sep 28, 2020
* Resolves a hidden step needed before adding a file to the types folder that can be confusing for developers new to the SDK codebase. * Discussion here: #48 (comment)
willmanduffy
added a commit
that referenced
this pull request
Sep 28, 2020
* Resolves a hidden step needed before adding a file to the types folder that can be confusing for developers new to the SDK codebase. * Discussion here: #48 (comment)
blairworkos
pushed a commit
that referenced
this pull request
Jan 29, 2021
* Returns a list of the organizations accessible to the provided API key. Includes pagination functionality via the list_metadata property.
blairworkos
pushed a commit
that referenced
this pull request
Jan 29, 2021
* Resolves a hidden step needed before adding a file to the types folder that can be confusing for developers new to the SDK codebase. * Discussion here: #48 (comment)
blairworkos
pushed a commit
that referenced
this pull request
Mar 3, 2021
* Returns a list of the organizations accessible to the provided API key. Includes pagination functionality via the list_metadata property.
blairworkos
pushed a commit
that referenced
this pull request
Mar 3, 2021
* Resolves a hidden step needed before adding a file to the types folder that can be confusing for developers new to the SDK codebase. * Discussion here: #48 (comment)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
API key. Includes pagination functionality via the list_metadata
property.