Use require_all to pull in types folder#53
Merged
willmanduffy merged 1 commit intomasterfrom Sep 28, 2020
Merged
Conversation
willmanduffy
force-pushed
the
require_all_types
branch
from
43943d8 to
5fd089f
Compare
willmanduffy
commented
Sep 14, 2020
| @@ -1,15 +1,11 @@ | |||
| # frozen_string_literal: true | |||
| # typed: strong | |||
Contributor
Author
There was a problem hiding this comment.
Had to remove this from this file to get srb tc to pass on require_all. Would the real solution be to write types for it?
Member
There was a problem hiding this comment.
🤔 Not sure, I don't know Sorbet that well tbh
Codecov Report
@@ Coverage Diff @@
## master #53 +/- ##
==========================================
- Coverage 98.68% 98.66% -0.02%
==========================================
Files 20 20
Lines 379 374 -5
==========================================
- Hits 374 369 -5
Misses 5 5
Continue to review full report at Codecov.
|
marktran
approved these changes
Sep 14, 2020
* Resolves a hidden step needed before adding a file to the types folder that can be confusing for developers new to the SDK codebase. * Discussion here: #48 (comment)
willmanduffy
force-pushed
the
require_all_types
branch
from
5fd089f to
79255ed
Compare
willmanduffy
added a commit
that referenced
this pull request
Sep 28, 2020
This reverts commit bf27cb5.
Merged
willmanduffy
added a commit
that referenced
this pull request
Sep 28, 2020
blairworkos
pushed a commit
that referenced
this pull request
Jan 29, 2021
* Resolves a hidden step needed before adding a file to the types folder that can be confusing for developers new to the SDK codebase. * Discussion here: #48 (comment)
blairworkos
pushed a commit
that referenced
this pull request
Jan 29, 2021
blairworkos
pushed a commit
that referenced
this pull request
Mar 3, 2021
* Resolves a hidden step needed before adding a file to the types folder that can be confusing for developers new to the SDK codebase. * Discussion here: #48 (comment)
blairworkos
pushed a commit
that referenced
this pull request
Mar 3, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
folder that can be confusing for developers new to the SDK
codebase.