refactor(rpc): preserve structured error responses - #434
Merged
Conversation
crystalt
requested review from
Dzejkop,
Guardiola31337,
aurel-fr,
karankurbur,
murph,
paolodamico and
sideround
as code owners
September 3, 2026 18:40
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Contributor
Author
|
@codex review |
karankurbur
approved these changes
Sep 3, 2026
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: be8c4732d3
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes the internal
rpc_callretain the complete JSON-RPC error response, including optional structureddata. Existing public RPC methods continue converting errors to the currentRpcErrorshape, so their behavior and API remain unchanged.This provides a lossless internal boundary for callers that need to interpret structured errors.
Note
Low Risk
Refactor of internal RPC error typing with public APIs unchanged; risk is limited to subtle error-handling regressions inside
rpc_call.Overview
Internal
rpc_callnow keeps full JSON-RPC errors instead of collapsing them intoRpcError::RpcResponseErrorimmediately. JSON-RPC failures returnRpcCallError::ResponsecarryingJsonRpcError(renamed fromErrorPayload), including optional structureddata.Public RPC helpers still surface
RpcErrorviamap_err(RpcError::from), so external behavior stays the same:RpcResponseErroronly exposes code and message (datais dropped at the API boundary).From<JsonRpcError>forRpcErrorencodes that mapping.custom_bundlerparsing follows theJsonRpcErrorrename. Tests add a stub HTTP client and assertrpc_callpreserveserror.datafor structured declines (e.g. policy/retry hints).Reviewed by Cursor Bugbot for commit be8c473. Bugbot is set up for automated code reviews on this repo. Configure here.