feat(transactions): prepare ERC-20 transfers before signing - #439
Merged
Conversation
crystalt
requested review from
Dzejkop,
Guardiola31337,
aurel-fr,
karankurbur,
murph,
paolodamico and
sideround
as code owners
September 4, 2026 22:17
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Base automatically changed from
crystalbilly/crypto-68-typed-sponsorship-decline
to
main
September 8, 2026 17:20
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6351fc0344
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
karankurbur
reviewed
Sep 9, 2026
karankurbur
reviewed
Sep 9, 2026
karankurbur
reviewed
Sep 9, 2026
karankurbur
reviewed
Sep 9, 2026
karankurbur
approved these changes
Sep 10, 2026
crystalt
deleted the
crystalbilly/crypto-70-prepared-erc20-lifecycle
branch
September 11, 2026 19:23
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the first client-side ERC-20 transaction lifecycle in Bedrock.
prepare_transaction_transferconstructs the exact unsigned UserOperation, requests sponsorship frompm_sponsorUserOperation(V2), and returns an opaque prepared transaction.submit_prepared_transactionsigns and submits that same operation through/v2/rpc/worldchain.This intentionally covers the sponsored happy path only. WLD self-sponsorship and its cost advisory remain follow-up work.
Stacked on #435, which provides the typed
pm_sponsorUserOperationresponse.Note
Medium Risk
Changes the public ERC-20 transfer API and submission path (V2 sponsor + send); sponsorship decline is a hard error with no fallback yet.
Overview
Splits World Chain ERC-20 transfers into a prepare → submit flow so clients can review an unsigned operation (with sponsorship applied) before signing.
prepare_transaction_transferbuilds the preflightUserOperation, callspm_sponsorUserOperationwith protocol sponsorship context, merges approved paymaster/gas fields via newUserOperation::with_pm_sponsorship_approval, and returns aPreparedTransaction(UniFFI object). Declined sponsorship currently errors out (self-sponsor left as TODO).submit_prepared_transactionchecks the prepared sender matches the account, signs the operation, and submits throughsend_user_operation_v2. Structured logging was added for both stages.Supporting changes: test HTTP mock handles
pm_sponsorUserOperation;PmSponsorshipDeclineReasongetsDisplay+EnumIterand a serde round-trip test; the Anvil integration test now asserts balances are unchanged until submit.Reviewed by Cursor Bugbot for commit b4e1d30. Bugbot is set up for automated code reviews on this repo. Configure here.