feat(react): add compact qr handoff option - #312
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
03501b5 to
f092813
Compare
f092813 to
c6803ed
Compare
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c6803edc85
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| {showMobileQR && ( | ||
| <div className="idkit-mobile-qr"> |
There was a problem hiding this comment.
On compact viewports where the expanded handoff exceeds 95vh—for example, a 375×667 phone—the newly rendered QR adds roughly 186px beneath the actions, but .idkit-modal is capped at max-height: 95vh with overflow: hidden, and neither it nor .idkit-content is scrollable. Consequently, the bottom of the QR and footer are clipped with no way to reach them; the compact modal or its content needs vertical scrolling when this section is expanded.
Useful? React with 👍 / 👎.
2 participants
This was something we had in the old idkit repo but never got ported. RPs/developer run into this a lot when they have their browser/app on the side under the 768px media query, they're expecting to see the QR code so they can test their flow...