Conversation
sky-mart
reviewed
Apr 21, 2026
| &self, | ||
| keyexpr: &str, | ||
| payload: impl Serialize, | ||
| ) -> Result<Result<Sample, ReplyError>> { |
Collaborator
Author
There was a problem hiding this comment.
yeee
1st one is infra error
2nd one must be handled, ReplyErr contains actual error payload which is nice from zenoh
look a little awkward on type but usage in practice is pretty smooth bc outer error is color_eyre (see tests / examples)
Contributor
|
I'm not yet familiar with all rust features used, but overall looks good.
|
sky-mart
approved these changes
Apr 21, 2026
Collaborator
Author
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
changes
adds and documents extension methods for the Zenoh Orb Command Interface: small helpers for sending commands using zenoh queries and using strings/json underneath
small example, using utility methods:
Query::argsQuery::reszenorb::Session::command_rawResult<Reply, ReplyErr>::json