Optimised Montgomery squaring#108
Merged
Merged
Conversation
Collaborator
|
Can you rebase this branch against main? There are no conflicts but main now has a passing CI pipeline |
Dzejkop
approved these changes
May 30, 2025
dcbuild3r
pushed a commit
that referenced
this pull request
May 16, 2026
* HLA: add support for lazy evaluation * lazy u256 multiplier * widening_mul_u256: split outer product from accumulator * codegen: single step montgomery squaring * codegen: squaring SIMD * block-multiplier: add block squaring * block-multiplier: add test * skyscraper: replace multiplier by squaring * block-multiplier: refactor tests * block-multiplier: compare montgomery_square_interleaved to ark-ff * clippy improvements * hla: safer interface for Lazy * fixup rebase * refactor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces optimised Montgomery squaring for both scalar and SIMD.
Additionally:
test_utilsto share code between tests.Note: the reducer hasn't been taken out yet. That will be done in a follow-up PR.