Reductionless block multipliers#116
Merged
Merged
Conversation
CodSpeed Walltime Performance ReportMerging #116 will degrade performances by 59.99%Comparing
|
| Benchmark | BASE |
HEAD |
Change | |
|---|---|---|---|---|
| ⚡ | ark_ff |
6.3 µs | 4 µs | +58.05% |
| ❌ | block_mul |
4.1 µs | 5.1 µs | -20.54% |
| ❌ | montgomery_interleaved_3 |
3.8 µs | 4.6 µs | -18.12% |
| ⚡ | montgomery_interleaved_4 |
6.3 µs | 3.9 µs | +60.57% |
| ⚡ | scalar_mul |
6.1 µs | 3.9 µs | +57.53% |
| ⚡ | simd_mul |
7.1 µs | 4.5 µs | +58.2% |
| ❌ | ark_ff |
5.2 µs | 6.6 µs | -20.96% |
| ⚡ | block_sqr |
5.8 µs | 3.7 µs | +56.92% |
| ❌ | scalar_sqr |
5 µs | 6.3 µs | -21.1% |
| ❌ | simd_sqr |
5.4 µs | 6.8 µs | -20.88% |
| ❌ | wrm_overhead |
1.7 µs | 4.4 µs | -59.99% |
| ⚡ | block3 |
190.2 µs | 164.8 µs | +15.43% |
| ⚡ | block4 |
233.1 µs | 198.2 µs | +17.63% |
| ⚡ | bits_20_fixed |
183.9 ms | 156.6 ms | +17.41% |
Collaborator
Author
|
Needs to be rebased on main since #108 has been merged. |
recmo
approved these changes
Jun 2, 2025
dcbuild3r
pushed a commit
that referenced
this pull request
May 16, 2026
Reductionless block multipliers
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the reduction step from the scalar and SIMD codegenerators. This gives the caller freedom to choose what kind of reduction strategy to employ.
Additionally, this adds code generators for a 2-round (log jump) Montgomery multiplier and squarer. Without the reducer, the output of the single-step squarer is too high to be used in the square operation of Skyscraper.
stacked on top of #108
closes #120