test(cliffs): score the error budget with the config that actually ships (#84) - #112
Merged
Merged
Conversation
…ips (#84) `cliffErrorBudget.spec.ts`'s constant named `SHIPPED` did not set `rejectAtCrossingStage`, which landed in `renderVulcanusCliffs.ts` with #108. So the file pinned the pre-#108 model - 25 surplus and precision 0.9839 - while the shipping path was at 22 and 0.9858, and it is the file people read for "current accuracy". The port is unchanged; only the measurement was wrong. Corrected figures over the same three oracle regions: | | position only | position AND orientation | | --- | --- | --- | | recall | 0.9961 (1525/1531) | 0.9824 (1504/1531) | | precision | 0.9858 (1525/1547) | 0.9722 (1504/1547) | 1504 matched, 21 wrong orientation, 22 surplus, 6 missing. Also in this file: - `SHIPPED` now carries a comment saying it must mirror the renderer's call, naming this drift as the reason. - The "precision is the dominant defect" guard goes from `x4` to `x3`, because the gap narrowed by #108 removing 3 surplus cells and no missing ones - the improvement working, not a weakened test. - The entity-collision block said item 3 was OPEN and "rocks are the lead". #111 closed it with a lever, so the block is retitled and points there; its two arms are kept as independent corroboration, and the one statistic in them that was measured at 25 surplus is marked as history rather than silently re-quoted. Same treatment for two other stale quotes: the NOTES banner people are told to read before quoting an accuracy number, and a prose figure in `cliffPhantomNeighbour.spec.ts` (whose assertions run with rejections off and do not depend on it). Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015C8AbtvYMdc7ed3rnAZbhP
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cliffErrorBudget.spec.tsdefines a constant namedSHIPPEDthat did not setrejectAtCrossingStage, which landed inrenderVulcanusCliffs.tswith #108. So the file pinned the pre-#108 model - 25 surplus, precision 0.9839 - while the shipping path was at 22 and 0.9858. That is the file people read for "current accuracy", so the drift is worth more than its size.The port is unchanged. Only the measurement was wrong.
Corrected figures, three oracle regions, 1531 game cells
1504 matched, 21 wrong orientation, 22 surplus, 6 missing. Per region:
[0,0]4 wrong / 2 surplus / 2 missing,[1500,1500]16 / 19 / 3,[-1200,800]1 / 1 / 1. Nauvis stays exact both ways.Also in this file
SHIPPEDcarries a comment saying it must mirror the renderer's call, naming this drift as the reason.x4->x3. Not a weakened test: the gap narrowed because feat(cliffs): the rejections act on the CROSSING, not on the entity (#84) #108 removed 3 surplus cells and no missing ones.Same treatment for two other stale quotes: the NOTES banner readers are told to consult before quoting any accuracy number, and a prose figure in
cliffPhantomNeighbour.spec.ts(whose assertions all run with rejections off and do not depend on it).pnpm run verifygreen (1399 tests).🤖 Generated with Claude Code
https://claude.ai/code/session_015C8AbtvYMdc7ed3rnAZbhP