docs(roadmap): retire three cliff TODOs that measurement has falsified - #69
Merged
Conversation
client-preview-ROADMAP.md still carried three items as open work that are not open, and one of them as a to-do for a rule the game does not have. The roadmap is what someone reads before picking up cliff work, so these read as the next thing to build. - "Ore excluded from cliffs" -> WITHDRAWN. generateCliffs() (0x1016229b4) touches no tile, entity or resource data, so there is no exclusion to port (#24, now closed). The observation behind it also fails its own null: region [0,0]'s 945 ore tiles are 2 blobs, and a torus-shift null leaves two of three regions not significant (P = 0.51, 0.29). - "Still deferred: fixImpossibleCells" -> ported in PR #32 (dea73ac), and it changes ZERO predictions, so it never explained the ~6% residual. - "Still deferred: wouldCollide" -> moot; no Nauvis cliff touches water. The residual stays open, reclassified by PR #57 as a rule error rather than a field error. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01BkKb3S2cGyRFFHSzuCQBgj
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bookkeeping half of the issue #16-#24 audit. No code changes.
docs/noise/client-preview-ROADMAP.mdis what someone reads before picking up cliff work, and it still listed three things as open that are not - one of them a to-do for a rule the game does not have.fixImpossibleCells"dea73ac), changes zero predictionswouldCollide"Each was verified against the repo before editing, not taken from a summary:
cliffPlacement.ts:105andtest/cliffFixImpossibleCells.spec.tsexist;dea73acmerged 2026-07-28T17:36Z.The Nauvis residual itself stays open. PR #57 reclassified it from a field error to a rule error, and the roadmap now says that rather than pointing at three retired causes.
Done alongside this, on GitHub
generateCliffs()(0x1016229b4) touches no resource data, so cause 1 had nothing to implement; cause 2 re-points at Vulcanus cliffs: 12.5% of matched cells get the wrong cliff_orientation (residual after the placement-count fixes) #18. Its sharpest artifact - 47 cliff cells our rule places inside entirely-calcite footprints where the game places 0 - was carried over to Vulcanus cliffs: 12.5% of matched cells get the wrong cliff_orientation (residual after the placement-count fixes) #18 rather than lost.This is the failure mode
documented-rationales-expiredescribes: a register whose entries are wrong is worse than no register.